Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
ensure compatibility with older PHPUnit mocks#29934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJan 19, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| $this->assertEquals(['a1' =>$ac1],$classMetadata2->getAttributesMetadata()); | ||
| $this->assertSame(['a','b','c'],$ac1->getGroups()); | ||
| $this->assertEquals(['a1' =>$ac1],$classMetadata1->getAttributesMetadata()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@dunglas Can you have a look here? Reading the code the previous assertion on$classMetadata2 IMO was wrong and only accidentally worked because of our mock configuration line 62. Can you confirm that the change here is valid?
a309317 to8780184Compare| /** | ||
| * @dataProvider methodExceptGetProvider | ||
| */ | ||
| publicfunctiontestSubmitFileWithNamelessForm($method) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This test was completely broken and just worked because our mocked form behaved completely different from how a real form would behave. I am looking into a proper fix in a different PR.
e2de9f6 to73369e7CompareUh oh!
There was an error while loading.Please reload this page.
51dfa67 to0b2546fCompare0b2546f to0d9de7eComparenicolas-grekas commentedJan 25, 2019
Thank you@xabbuh. |
This PR was merged into the 3.4 branch.Discussion----------ensure compatibility with older PHPUnit mocks| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------0d9de7e [Form] ensure compatibility with older PHPUnit mocks
This PR was merged into the 3.4 branch.Discussion----------[Form] add back test after fixing it| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29934 (comment)| License | MIT| Doc PR |Commits-------0daeba8 add back test after fixing it
This PR was merged into the 3.4 branch.Discussion----------[Form] add back test after fixing it| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |symfony/symfony#29934 (comment)| License | MIT| Doc PR |Commits-------0daeba8e8a add back test after fixing it