Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] forward the parse error to the calling code#29928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
javiereguiluz approved these changesJan 18, 2019
Member
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice! Thank you.
chalasr approved these changesJan 18, 2019
Contributor
przemyslaw-bogusz commentedJan 19, 2019
We could implement an analogical change inXMLFileLoader, for users, who configure services using XML: symfony/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php Lines 381 to 392 inb972d15
|
fabpot approved these changesJan 20, 2019
Member
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you do the same for the XML loader?
MemberAuthor
xabbuh commentedJan 20, 2019
done |
Member
fabpot commentedJan 20, 2019
Thank you@xabbuh. |
fabpot added a commit that referenced this pull requestJan 20, 2019
…ling code (xabbuh)This PR was merged into the 3.4 branch.Discussion----------[DependencyInjection] forward the parse error to the calling code| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29891| License | MIT| Doc PR |This change does not fully solve the linked issue, but improves the exception a bit by providing a bit more context.The error page will no start like this:Commits-------c5c2d31 forward the parse error to the calling code
fabpot added a commit that referenced this pull requestJan 20, 2019
This PR was merged into the 3.4 branch.Discussion----------[DependencyInjection] fix tests| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29928| License | MIT| Doc PR |My changes in#29928 broke the test suite.Commits-------4db0a6e fix tests
nicolas-grekas added a commit that referenced this pull requestFeb 7, 2019
…of Debug (javiereguiluz)This PR was squashed before being merged into the 4.3-dev branch (closes#30024).Discussion----------[Debug] Display more details in the simple error page of Debug| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29891| License | MIT| Doc PR | -Note: this only changes the simple error page of Debug component, which is different from the full-featured error page of WebProfilerBundle.-----#29891 shows a confusing error page. In#29928 we improved the first error message displayed to the user. In this PR we implement@nicolas-grekas' idea to replace the generic error page title by a better error message. So, this PR +#29928 wouldfix#29891 to me.### Before### AfterCommits-------75ff151 [Debug] Display more details in the simple error page of Debug
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does not fully solve the linked issue, but improves the exception a bit by providing a bit more context.
The error page will no start like this: