NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Form] Changed UrlType input type to text when default_protocol is not null#29926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:3.4fromxabbuh:pr-29691

Jan 25, 2019

Merged

[Form] Changed UrlType input type to text when default_protocol is not null#29926

nicolas-grekas merged 1 commit intosymfony:3.4fromxabbuh:pr-29691

Jan 25, 2019

Conversation

Copy link

Member

xabbuh commentedJan 18, 2019

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#29690
License	MIT
Doc PR

replaces#29691

[Form] Changed UrlType input type to text when default_protocol is no…

2791edf

…t null

xabbuh added this to the3.4 milestone

Jan 18, 2019

carsonbot added Status: Needs Review Form Bug labels

Jan 18, 2019

stof approved these changes

Jan 23, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jan 23, 2019

Copy link

Member

nicolas-grekas commentedJan 25, 2019

Thank you@xabbuh.

nicolas-grekas merged commit2791edf intosymfony:3.4

Jan 25, 2019

nicolas-grekas added a commit that referenced this pull request

Jan 25, 2019

bug#29926[Form] Changed UrlType input type to text when default_pro…

e3b010f

…tocol is not null (MatTheCat)This PR was merged into the 3.4 branch.Discussion----------[Form] Changed UrlType input type to text when default_protocol is not null| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#29690| License       | MIT| Doc PR        |replaces#29691Commits-------2791edf [Form] Changed UrlType input type to text when default_protocol is not null