Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Debug][DebugClassLoader] Match more cases for final, deprecated and internal classes / methods extends#29920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromfancyweb:match-more-cases-in-debug-class-loaderJan 24, 2019
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…internal classes / methods extends
nicolas-grekas approved these changesJan 24, 2019
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM thanks.
BTW, if you'd like to have a look at#29969, it's on the same line :)
Member
nicolas-grekas commentedJan 24, 2019
Thank you@fancyweb. |
nicolas-grekas added a commit that referenced this pull requestJan 24, 2019
…ecated and internal classes / methods extends (fancyweb)This PR was merged into the 3.4 branch.Discussion----------[Debug][DebugClassLoader] Match more cases for final, deprecated and internal classes / methods extends| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Currently, when there is no comment for a tag and another tag after, the detection does not work. Example :```php/** *@Final * *@author John */class A {}```AFAIK, those tags must not be in a specific order. That's why we should try to support more cases because we might miss things to report.Also I do not understand why the regex is not the same for the classes and methods detection. I fixed that too.I added a lot of cases in the "extends from final class" test and an easy way to add more when needed. Adding them everywhere might be overkill and useless. WDYT ?I'm considering this as bug fix.Commits-------c3b670a [Debug][DebugClassLoader] Match more cases for final, deprecated and internal classes / methods extends
This was referencedJan 29, 2019
Merged
Merged
Merged
fabpot added a commit that referenced this pull requestMar 4, 2019
…bbuh)This PR was merged into the 3.4 branch.Discussion----------[Debug] detect annotations before blank docblock lines| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This fixes the tests and a small issue after the CS changes made indf1d50d for#29920.Commits-------dedd526 detect annotations before blank docblock lines
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when there is no comment for a tag and another tag after, the detection does not work. Example :
AFAIK, those tags must not be in a specific order. That's why we should try to support more cases because we might miss things to report.
Also I do not understand why the regex is not the same for the classes and methods detection. I fixed that too.
I added a lot of cases in the "extends from final class" test and an easy way to add more when needed. Adding them everywhere might be overkill and useless. WDYT ?
I'm considering this as bug fix.