Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mime] Add the component#29896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 4 commits intosymfony:masterfromfabpot:mime-type-component
Jan 17, 2019
Merged

Conversation

@fabpot
Copy link
Member

@fabpotfabpot commentedJan 15, 2019•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#28832#21985 makes#15460 trivial
LicenseMIT
Doc PRsymfony/symfony-docs#10886

This has been on my todo-list for X years :)

smoench, Pierstoval, yceruto, kissifrot, mykiwi, deguif, and apfelbox reacted with thumbs up emojiKocal, Pierstoval, yceruto, fsevestre, deguif, sstok, and andreybolonin reacted with hooray emoji
@fabpotfabpotforce-pushed themime-type-component branch 2 times, most recently fromac0eda7 to7f7f4b8CompareJanuary 16, 2019 06:51
@teohhanhui
Copy link
Contributor

It'd be good to add a test for SVG:#15460 (comment)

@javiereguiluz
Copy link
Member

Last question from me: should we provide autoconfiguration for the newMimeTypeGuesserInterface? thanks.

@fabpot
Copy link
MemberAuthor

Autoconfig is already there, so if you create a class with this interface, it will be tagged automatically and registered.

javiereguiluz reacted with thumbs up emoji

@fabpot
Copy link
MemberAuthor

@teohhanhui The underlying guessers are the same as before, so that won't fix the mentioned issue.

* @see Resources/bin/update_mime_types.php
*/
private static $map = [
'application/acrobat' => ['pdf'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does this kind of list scale? Even currently browser has trouble opening this file in github. It's almost 2000 entries now. Implementation of updating it could also be simpler if it was in external file and just var_export used. This point was raised by somebody in Slack originally.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Scale in what sense? Displaying it on Github is not a goal. PHP manages it fairly well and is even able to optimize it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Goal should be scale it for both PHP and human reviewing the core functionality of MimeTypes.php. Currently this list is mostly just noise for human since it's something generated. Thanks to Opcache it should be fairly good optimized with external file as well, shouldn't it?

chalasr
chalasr previously requested changesJan 16, 2019
@fabpotfabpot dismissedchalasr’sstale reviewJanuary 16, 2019 23:02

Everything fixed, thank you

@fabpotfabpot merged commitbdca5d9 intosymfony:masterJan 17, 2019
fabpot added a commit that referenced this pull requestJan 17, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes#29896).Discussion----------[Mime] Add the component| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#28832#21985 makes#15460 trivial| License       | MIT| Doc PR        |symfony/symfony-docs#10886This has been on my todo-list for X years :)Commits-------bdca5d9 tweaked code5268389 [Mime] added freedesktop as a source for mime types74ca91d [Mime] added the componentd7ee0ec [HttpFoundation] updated File code
@fabpotfabpot deleted the mime-type-component branchJanuary 17, 2019 07:08
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
nicolas-grekas added a commit that referenced this pull requestJun 8, 2019
…anagi)This PR was merged into the 5.0-dev branch.Discussion----------[Serializer] Remove last deprecated/obsolete paths| Q             | A| ------------- | ---| Branch?       | master <!-- see below -->| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#28316,#28709,#31030,#27020,#29896,16f8a13#r201060750   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/A <!-- required for new features -->This should fix the last deprecations & obsolete code paths for the Serializer component.Commits-------c703b35 [Serializer] Remove last deprecated/obsolete paths
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr left review comments

+3 more reviewers

@hhamonhhamonhhamon left review comments

@ostroluckyostroluckyostrolucky left review comments

@linaorilinaorilinaori left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

9 participants

@fabpot@teohhanhui@javiereguiluz@hhamon@nicolas-grekas@ostrolucky@linaori@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp