Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[BrowserKit] Various changes to the Response class#29881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * | ||
| * @return int The response status code | ||
| */ | ||
| publicfunctiongetStatusCode():int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Consistent with the method name used byHttpFoundation
| */ | ||
| class Response | ||
| { | ||
| /** @internal */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@final is enough, just to be extra clear.
fb40550 toc13438cCompare…bpot)This PR was squashed before being merged into the 4.3-dev branch (closes#29881).Discussion----------[BrowserKit] Various changes to the Response class| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | yes| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aThis is the first PR of a series when I'm trying to "modernize" BrowserKit.Commits-------9045a4e [BrowserKit] marked Response as@Final0abff98 [BrowserKit] deprecated Response::buildHeader()e8e5235 [BrowserKit] deprecated Response::getStatus() in favor of Response::getStatusCode()
This is the first PR of a series when I'm trying to "modernize" BrowserKit.