Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Revert "bug #29597 [DI] fix reporting bindings on overriden services as unused"#29853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesJan 11, 2019
lyrixx approved these changesJan 11, 2019
Member
lyrixx left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This will reopen#28326
dunglas approved these changesJan 11, 2019
fabpot approved these changesJan 13, 2019
Member
fabpot commentedJan 13, 2019
Thank you@mmarynich. |
fabpot added a commit that referenced this pull requestJan 13, 2019
…n services as unused" (mmarynich)This PR was merged into the 3.4 branch.Discussion----------Revert "bug#29597 [DI] fix reporting bindings on overriden services as unused"This reverts commit44e9a91, reversingchanges made to91b28ff.| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29836| License | MIT| Doc PR |4.2.2 release changed the way tagged service are injectedAs asked by@nicolas-grekas#29836 (comment)Commits-------b3e17d2 Revert "bug#29597 [DI] fix reporting bindings on overriden services as unused (nicolas-grekas)"
xabbuh added a commit to xabbuh/symfony that referenced this pull requestJan 14, 2019
Insymfony#29853 the bugfix made insymfony#29597 was reverted as it did not work asexpected. This fixture file has been modified after the 3.4 branch wasmerged up to account for the changes made insymfony#2957 and must now bereverted to the former state too.
fabpot added a commit that referenced this pull requestJan 15, 2019
…abbuh)This PR was merged into the 4.2 branch.Discussion----------[DependencyInjection] fix test after revert of bugfix| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |In#29853 the bugfix made in#29597 was reverted as it did not work asexpected. This fixture file has been modified after the 3.4 branch wasmerged up to account for the changes made in#2957 and must now bereverted to the former state too.Commits-------81f63b1 fix test after revert of bugfix
This was referencedJan 16, 2019
This was referencedJan 29, 2019
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This reverts commit44e9a91, reversing
changes made to91b28ff.
4.2.2 release changed the way tagged service are injected
As asked by@nicolas-grekas#29836 (comment)