Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] xliff-version option to translation update command#29850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@andrewwro
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?no
LicenseMIT

New 'version' option added to xliff translation update command. Currently xliff version is hardcoded to 1.2.

@andrewwroandrewwro changed the titleAdded xliff-version option to update translation file[FrameworkBundle] xliff-version option to translation update commandJan 11, 2019
Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wondered if we should validate the given version somehow ... but in addition to complicating things, not doing that gives more flexibility for edge-cases where developers may need to use a non-standard looking version. So I think the proposed changes are enough. Thanks!

@stof
Copy link
Member

@javiereguiluz the XliffDumper already validates the version.

@andrewwroandrewwroforce-pushed thetranslation-update-command-xliff-version-option branch from6c1d13d toe908bedCompareJanuary 18, 2019 15:21
@nicolas-grekasnicolas-grekas added this to thenext milestoneJan 24, 2019
@nicolas-grekasnicolas-grekasforce-pushed thetranslation-update-command-xliff-version-option branch frome908bed to4ec28bdCompareJanuary 24, 2019 20:08
@nicolas-grekas
Copy link
Member

Thank you@andrewwro.

@nicolas-grekasnicolas-grekas merged commit4ec28bd intosymfony:masterJan 24, 2019
nicolas-grekas added a commit that referenced this pull requestJan 24, 2019
…update command (andrewwro)This PR was squashed before being merged into the 4.3-dev branch (closes#29850).Discussion----------[FrameworkBundle] xliff-version option to translation update command| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | no    <!-- please add some, will be required by reviewers -->| License       | MITNew 'version' option added to xliff translation update command. Currently xliff version is hardcoded to 1.2.Commits-------4ec28bd [FrameworkBundle] xliff-version option to translation update command
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof requested changes

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@andrewwro@stof@nicolas-grekas@fabpot@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp