Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Fixed #29835: ConfirmationQuestion with default true for answer '0'#29844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4frommrthehud:issue-29835
Jan 25, 2019

Conversation

@mrthehud
Copy link
Contributor

@mrthehudmrthehud commentedJan 11, 2019
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?Almost all, one failure on appveyor?
Fixed tickets#29835
LicenseMIT
Doc PRn/a

When using the ConfirmationQuestion class to ask a yes / no question,
if the default is true, and the answer regex is '/^y/i', then any
value not starting with [yY] is considered false.

This must include "0", which previously would return true, producing results such as:

$ php bin/console do:stuff$ Do you want to continue? 0 <enter>$ Ok, continuing!

@mrthehud
Copy link
ContributorAuthor

That Appveyor test that's failing looks completely unrelated, and passes locally. Any ideas chaps?

@chalasr
Copy link
Member

@mrthehud that's unrelated indeed, don't worry about it.

@nicolas-grekas
Copy link
Member

Thank you@mrthehud.

@nicolas-grekasnicolas-grekas merged commita0a7400 intosymfony:3.4Jan 25, 2019
nicolas-grekas added a commit that referenced this pull requestJan 25, 2019
…true for answer '0' (mrthehud)This PR was squashed before being merged into the 3.4 branch (closes#29844).Discussion----------[Console]Fixed#29835: ConfirmationQuestion with default true for answer '0'| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | Almost all, one failure on appveyor?| Fixed tickets |#29835| License       | MIT| Doc PR        | n/a<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->When using the ConfirmationQuestion class to ask a yes / no question,if the default is true, and the answer regex is '/^y/i', then anyvalue not starting with [yY] is considered false.This must include "0", which previously would return true, producing results such as:```$ php bin/console do:stuff$ Do you want to continue? 0 <enter>$ Ok, continuing!```Commits-------a0a7400 [Console]Fixed#29835: ConfirmationQuestion with default true for answer '0'
This was referencedJan 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@ro0NLro0NLro0NL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@mrthehud@chalasr@nicolas-grekas@ro0NL@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp