Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Fixed #29835: ConfirmationQuestion with default true for answer '0'#29844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ro0NL approved these changesJan 11, 2019
chalasr requested changesJan 11, 2019
src/Symfony/Component/Console/Tests/Question/ConfirmationQuestionTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
ContributorAuthor
mrthehud commentedJan 11, 2019
That Appveyor test that's failing looks completely unrelated, and passes locally. Any ideas chaps? |
Member
chalasr commentedJan 11, 2019
@mrthehud that's unrelated indeed, don't worry about it. |
Uh oh!
There was an error while loading.Please reload this page.
chalasr approved these changesJan 13, 2019
Member
nicolas-grekas commentedJan 25, 2019
Thank you@mrthehud. |
nicolas-grekas added a commit that referenced this pull requestJan 25, 2019
…true for answer '0' (mrthehud)This PR was squashed before being merged into the 3.4 branch (closes#29844).Discussion----------[Console]Fixed#29835: ConfirmationQuestion with default true for answer '0'| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | Almost all, one failure on appveyor?| Fixed tickets |#29835| License | MIT| Doc PR | n/a<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->When using the ConfirmationQuestion class to ask a yes / no question,if the default is true, and the answer regex is '/^y/i', then anyvalue not starting with [yY] is considered false.This must include "0", which previously would return true, producing results such as:```$ php bin/console do:stuff$ Do you want to continue? 0 <enter>$ Ok, continuing!```Commits-------a0a7400 [Console]Fixed#29835: ConfirmationQuestion with default true for answer '0'
This was referencedJan 29, 2019
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
When using the ConfirmationQuestion class to ask a yes / no question,
if the default is true, and the answer regex is '/^y/i', then any
value not starting with [yY] is considered false.
This must include "0", which previously would return true, producing results such as: