Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] AddLocaleTypeTest::testInvalidLocaleMessage()#29828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
LocaleTypeTest::testInvalidLocaleMessage()LocaleTypeTest::testInvalidLocaleMessage()xabbuh commentedJan 10, 2019
The current behaviour is expected. The |
phansys commentedJan 10, 2019
Thank you for the response. |
xabbuh commentedJan 10, 2019
Yes, that's right. But you can use the |
phansys commentedJan 10, 2019
In that case, I should instantiate manually the |
nicolas-grekas commentedJan 24, 2019
Should we merge this PR? If yes, please rebase to account for short arrays. If needed, please open an issue if there is anything to keep track of. |
e760446 toe882dfbComparexabbuh commentedFeb 1, 2019
The added test is failing as expected. I think for cases where the current behaviour is not sufficient enough, having to configure the |
phansys commentedFeb 1, 2019
Thank for your response. I think this behavior was changed between |
xabbuh commentedFeb 2, 2019
I think that's because before#29500 was merged, the |
phansys commentedFeb 2, 2019
Closing based on the given explanation. Thank you! |
Uh oh!
There was an error while loading.Please reload this page.
Since passing a invalid locale causes the form to be not synchronized, the validation fails because this reason instead of the locale validation.
Since I don't know if this is the expected result, this PR provides a test covering the described behavior in order to clarify the situation.