Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[EventDispatcher] Fix unknown priority#29822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromro0NL:event-prio
Feb 21, 2019
Merged

[EventDispatcher] Fix unknown priority#29822

fabpot merged 1 commit intosymfony:3.4fromro0NL:event-prio
Feb 21, 2019

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedJan 8, 2019
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

Somehow, after#29411 the profiler actually shows the security firewallContextListener.

This listener removes itself at call time, but at this point it's wrapped reference is already in the call stack; to be displayed in the profiler.

Because the wrapped listener lazily collects its priority - it asks it from the dispatcher - we get null; the listener was already removed.

This causes the profiler to render- by default:

image

This fixes it by always passing the expected priority at call time.

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedJan 8, 2019
edited
Loading

The PR conflicts a bit with upstream, during added constructor hints. Let me know what to do, i wasnt necessarily aiming to deprecate not passing this new argument, nor do i want to add a new setter.

Also im not sure about applying all short array changes here&now, on 3.4

edit: dropped the constructor arg, but still conflicts :)

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneJan 10, 2019
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJan 25, 2019
edited
Loading

could you please rebase?

@nicolas-grekas
Copy link
Member

rebase needed to retrigger the CI bots

@ro0NL
Copy link
ContributorAuthor

@nicolas-grekas done.

@fabpot
Copy link
Member

Thank you@ro0NL.

@fabpotfabpot merged commit9fb619a intosymfony:3.4Feb 21, 2019
fabpot added a commit that referenced this pull requestFeb 21, 2019
This PR was merged into the 3.4 branch.Discussion----------[EventDispatcher] Fix unknown priority| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Somehow, after#29411 the profiler actually shows the security firewall `ContextListener`.This listener removes itself at call time, but at this point it's wrapped reference is already in the call stack; to be displayed in the profiler.Because the wrapped listener lazily collects its priority - it asks it from the dispatcher -  we get null; the listener was already removed.This causes the profiler to render `-` by default:![image](https://user-images.githubusercontent.com/1047696/50850320-d5c5ee80-1379-11e9-8516-0c6bc54512ce.png)This fixes it by always passing the expected priority at call time.Commits-------9fb619a [EventDispatcher] Fix unknown priority
@ro0NLro0NL deleted the event-prio branchFebruary 21, 2019 08:34
This was referencedMar 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@ro0NL@nicolas-grekas@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp