Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[EventDispatcher] Fix unknown priority#29822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ro0NL commentedJan 8, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The PR conflicts a bit with upstream, during added constructor hints. Let me know what to do, i wasnt necessarily aiming to deprecate not passing this new argument, nor do i want to add a new setter. Also im not sure about applying all short array changes here&now, on 3.4 edit: dropped the constructor arg, but still conflicts :) |
nicolas-grekas commentedJan 25, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
could you please rebase? |
nicolas-grekas commentedFeb 20, 2019
rebase needed to retrigger the CI bots |
ro0NL commentedFeb 20, 2019
@nicolas-grekas done. |
fabpot commentedFeb 21, 2019
Thank you@ro0NL. |
This PR was merged into the 3.4 branch.Discussion----------[EventDispatcher] Fix unknown priority| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Somehow, after#29411 the profiler actually shows the security firewall `ContextListener`.This listener removes itself at call time, but at this point it's wrapped reference is already in the call stack; to be displayed in the profiler.Because the wrapped listener lazily collects its priority - it asks it from the dispatcher - we get null; the listener was already removed.This causes the profiler to render `-` by default:This fixes it by always passing the expected priority at call time.Commits-------9fb619a [EventDispatcher] Fix unknown priority
Uh oh!
There was an error while loading.Please reload this page.
Somehow, after#29411 the profiler actually shows the security firewall
ContextListener.This listener removes itself at call time, but at this point it's wrapped reference is already in the call stack; to be displayed in the profiler.
Because the wrapped listener lazily collects its priority - it asks it from the dispatcher - we get null; the listener was already removed.
This causes the profiler to render
-by default:This fixes it by always passing the expected priority at call time.