Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Always pass $key to NullAdapter->createCacheItem#29794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.2fromTysonAndre:patch-1
Jan 25, 2019

Conversation

@TysonAndre
Copy link
Contributor

@TysonAndreTysonAndre commentedJan 5, 2019•
edited
Loading

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes (build failure seems unrelated)
Fixed tickets
LicenseMIT
Doc PR

Previously, if this were called, it would throw an ArgumentCountError.
I'm assuming existing code always checks hasItem, so this bug hasn't impacted many people.
This was noticed via static analysis.

The get() method was added to NullAdapter in symfony 4.2

@TysonAndre
Copy link
ContributorAuthor

code to reproduce:

<?phprequire_once 'vendor/autoload.php';$x = new Symfony\Component\Cache\Adapter\NullAdapter();var_export($x->get('key', function (...$args) {}));  // would throw ArgumentCountError

Previously, if this were called, it would throw an ArgumentCountError.I'm assuming existing code always checks hasItem, so this bug hasn't impacted many people.This was noticed via static analysis.The get() method was added to NullAdapter in symfony 4.2
@nicolas-grekas
Copy link
Member

Good catch, thanks@TysonAndre.

@nicolas-grekasnicolas-grekas merged commit1976d29 intosymfony:4.2Jan 25, 2019
nicolas-grekas added a commit that referenced this pull requestJan 25, 2019
This PR was merged into the 4.2 branch.Discussion----------Always pass $key to NullAdapter->createCacheItem| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes (build failure seems unrelated)| Fixed tickets || License       | MIT| Doc PR        |Previously, if this were called, it would throw an ArgumentCountError.I'm assuming existing code always checks hasItem, so this bug hasn't impacted many people.This was noticed via static analysis.The get() method was added to NullAdapter in symfony 4.2Commits-------1976d29 Always pass $key to NullAdapter->createCacheItem
@fabpotfabpot mentioned this pull requestFeb 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@TysonAndre@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp