NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Intl] fixed tests by providing nullable type hints instead of strict ones#29785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Stas-Soroka wants to merge1 commit intosymfony:masterfromStas-Soroka:fix_tests_by_imporving_typehints

Closed

[Intl] fixed tests by providing nullable type hints instead of strict ones#29785

Stas-Soroka wants to merge1 commit intosymfony:masterfromStas-Soroka:fix_tests_by_imporving_typehints

Conversation

Copy link

Contributor

Stas-Soroka commentedJan 5, 2019

Q	A
Branch?	master
Bug fix?	no (test fix)
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#...
License	MIT

Currently testsIntlDateFormatterTest::testConstructorWithoutDateType andIntlDateFormatterTest::testConstructorWithoutTimeType are not passing because of strict type hints fordatetype andtimetpye parameters in IntlDateFormatter class contructor, whereas PHPDoc hints that these parameters are nullable. This PR resolves it, and makes all tests in the Intl test suite pass.