Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpFoundation] MemcachedSessionHandler::close() must close connection#29783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@grachevko
Copy link
Contributor

@grachevkograchevko commentedJan 4, 2019
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
LicenseMIT

Intoduced here#3333

@grachevkograchevko changed the base branch frommaster to3.4January 4, 2019 21:08
@grachevkograchevkoforce-pushed thebugfix/memcached-close branch 4 times, most recently fromb77e76a to2bd3c98CompareJanuary 6, 2019 19:23
@chalasrchalasr added this to the3.4 milestoneJan 8, 2019
@fabpot
Copy link
Member

/cc@stof Can you have a look here as you did the opposite patch in the referenced PR?

@SpacePossum
Copy link
Contributor

Kindly note: in the linked PR the call toMemcached#close was removed (:+1: ), here however the call toMemcached#quit is proposed. That method is around since 2.0.0 but feature detection could be applied.

@nicolas-grekas
Copy link
Member

Thank you@grachevko.

@nicolas-grekasnicolas-grekas merged commit38a9d8b intosymfony:3.4Jan 25, 2019
nicolas-grekas added a commit that referenced this pull requestJan 25, 2019
…se connection (grachevko)This PR was merged into the 3.4 branch.Discussion----------[HttpFoundation] MemcachedSessionHandler::close() must close connection| Q             | A| ------------- | ---| Branch?       | 3.4 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| License       | MITIntoduced here#3333Commits-------38a9d8b [Bugfix] MemcachedSessionHandler::close() must close connection
@grachevkograchevko deleted the bugfix/memcached-close branchJanuary 25, 2019 11:21
This was referencedJan 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@SpacePossumSpacePossumSpacePossum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@grachevko@fabpot@SpacePossum@nicolas-grekas@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp