Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Replace slave and master by replica and primary#29744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesJan 1, 2019
ContributorAuthor
Mx-Glitter commentedJan 1, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
AppVeyor build failed and is hanginghere Screenshot and output in case build window is not available anymore Output |
ogizanagi approved these changesJan 2, 2019
fabpot approved these changesJan 2, 2019
Remove racially charged terms.
3a9cb37 tof06e6b4CompareMember
fabpot commentedJan 2, 2019
Thank you@Mx-Glitter. |
fabpot added a commit that referenced this pull requestJan 2, 2019
…ter)This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes#29744).Discussion----------Replace slave and master by replica and primary| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29735| License | MIT| Doc PR |I targeted 4.2 branch because the words were introduced in it cf.#27291Commits-------f06e6b4 Replace slave and master by replica and primary
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I targeted 4.2 branch because the words were introduced in it cf.#27291