Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] handle null date and time types#29738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedDec 31, 2018
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29705 |
| License | MIT |
| Doc PR |
ro0NL left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
getDateType +static create() also need a patch
Uh oh!
There was an error while loading.Please reload this page.
xabbuh commentedJan 3, 2019
@ro0NL I fail to see which change is needed for |
ro0NL left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
never mind, $dateType cant be null anymore :)
nicolas-grekas commentedJan 3, 2019
Thank you@xabbuh. |
This PR was merged into the 3.4 branch.Discussion----------[Intl] handle null date and time types| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29705| License | MIT| Doc PR |Commits-------6ded31a [Intl] handle null date and time types