Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PHPUnitBridge] Static access in closure#29724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@greg0ire
Copy link
Contributor

@greg0iregreg0ire commentedDec 29, 2018•
edited
Loading

QA
Branch?master for features
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn / a
LicenseMIT
Doc PRn / a

#29718 bumps php to 5.5 . This is what we could simplify if it gets merged, thanks to this "new" PHP feature:https://3v4l.org/sJOWr

EDIT: it was merged, this can be reviewed.

@greg0ire
Copy link
ContributorAuthor

Doing many commits for now, in case some of them cannot be merged. Will squash if everything is all good.

@greg0iregreg0ireforce-pushed thestatic_access_in_closure branch 2 times, most recently from8df51b1 toe90bfefCompareDecember 30, 2018 09:18
@greg0ire
Copy link
ContributorAuthor

Prepended the commit list with one cs-fix commit (self accessor), apparently the code wasn't even valid before any changes. Got rid of the fabbot commit by dispatching changes to the right commits.

@greg0iregreg0ireforce-pushed thestatic_access_in_closure branch frome90bfef to5345897CompareDecember 30, 2018 09:35
@greg0ire
Copy link
ContributorAuthor

The Travis failure seems unrelated.

@greg0iregreg0ire changed the titleStatic access in closure[PHPUnitBridge] Static access in closureDec 30, 2018
@greg0iregreg0ireforce-pushed thestatic_access_in_closure branch from5345897 to2584634CompareJanuary 1, 2019 18:18
@nicolas-grekasnicolas-grekas added this to thenext milestoneJan 3, 2019
@greg0iregreg0ireforce-pushed thestatic_access_in_closure branch 2 times, most recently from17417bb tob7100b3CompareJanuary 3, 2019 15:29
@greg0ire
Copy link
ContributorAuthor

The build failures are unrelated, please review again@nicolas-grekas

@greg0iregreg0ireforce-pushed thestatic_access_in_closure branch 2 times, most recently from1a12b1c to79921b3CompareJanuary 14, 2019 19:49
@nicolas-grekas
Copy link
Member

rebase needed please, but before, I'd recommend you to squash+apply move to short arrays.

@greg0iregreg0ireforce-pushed thestatic_access_in_closure branch from79921b3 to7bee301CompareJanuary 25, 2019 13:34
}

$UtilPrefix =class_exists('PHPUnit_Util_ErrorHandler') ?'PHPUnit_Util_' :'PHPUnit\Util\\';
self::computeMode($mode);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Computing the mode should be kept lazy: it allows registering the bridge and configure the mode a bit later before any deprecation is thrown. That's an important behavior we should keep.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok, I introduced a new$rawMode static to keep the value until it is necessary to compute the actual mode.

@greg0iregreg0ireforce-pushed thestatic_access_in_closure branch from7bee301 to9df76ebCompareJanuary 27, 2019 17:08
@nicolas-grekas
Copy link
Member

I pushed a 2nd commit here, that uses an internal instance instead of static properties to track the state.
I also gave up preserving original ordering :)

@nicolas-grekas
Copy link
Member

Thank you@greg0ire.

@nicolas-grekasnicolas-grekas merged commit97f3023 intosymfony:masterJan 27, 2019
nicolas-grekas added a commit that referenced this pull requestJan 27, 2019
…las-grekas)This PR was merged into the 4.3-dev branch.Discussion----------[PHPUnitBridge] Static access in closure| Q             | A| ------------- | ---| Branch?       | master for features| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n / a| License       | MIT| Doc PR        | n / a#29718 bumps php to 5.5 . This is what we could simplify if it gets merged, thanks to this "new" PHP feature:https://3v4l.org/sJOWrEDIT: it was merged, this can be reviewed.Commits-------97f3023 Use the scope of an instance9df76eb Extract closures into static functions
@greg0iregreg0ire deleted the static_access_in_closure branchJanuary 27, 2019 18:13
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

3 participants

@greg0ire@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp