Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SecurityBundle] Fix traceable voters#29721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:4.2fromro0NL:voter
Jan 1, 2019
Merged

[SecurityBundle] Fix traceable voters#29721

chalasr merged 1 commit intosymfony:4.2fromro0NL:voter
Jan 1, 2019

Conversation

@ro0NL
Copy link
Contributor

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29385
LicenseMIT
Doc PRsymfony/symfony-docs#...

lets solve the BC break when autowiring individual voters.

@ro0NLro0NL changed the title[SecurityBundle] Fix tracable voters[SecurityBundle] Fix traceable votersDec 29, 2018
@xabbuh
Copy link
Member

Does it make sense to add a test which ensures that the original voter class can be retrieved from the compiled container?

@ro0NL
Copy link
ContributorAuthor

updated test to check voters are NOT decorated

@chalasrchalasr added this to the4.2 milestoneJan 1, 2019
@chalasr
Copy link
Member

Thank you@ro0NL.

@chalasrchalasr merged commita7df429 intosymfony:4.2Jan 1, 2019
chalasr pushed a commit that referenced this pull requestJan 1, 2019
This PR was squashed before being merged into the 4.2 branch (closes#29721).Discussion----------[SecurityBundle] Fix traceable voters| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? |  no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#29385| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->lets solve the BC break when autowiring individual voters.Commits-------a7df429 [SecurityBundle] Fix traceable voters
@ro0NLro0NL deleted the voter branchJanuary 1, 2019 10:55
@fabpotfabpot mentioned this pull requestJan 6, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot requested changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@ro0NL@xabbuh@chalasr@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp