Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PHPUnit bridge] Bump php version of PHPUnit-bridge#29718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@gmponos
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no (?)
Deprecations?no
Tests pass?yes
LicenseMIT

Related to#29623 (comment)

I checked the BC page I think I couldn't find any related to BC changes... anyway...

As far as I understood from the comment above I must targetmaster branch.

@gmponosgmponos changed the titleBump php version of PHPUnit-bridge[PHPUnit bridge] Bump php version of PHPUnit-bridgeDec 28, 2018
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

while bumping to phpunit5 & php5.5, there are many opportunities to improve the code (eg $this in closure, and polyfills that we could remove, see "Legacy" namespace.)
Up to do it?

@gmponos
Copy link
ContributorAuthor

while bumping to phpunit5

haven't bumped PHPUnit version..

there are many opportunities to improve the code (eg $this in closure, and polyfills that we could remove, see "Legacy" namespace

it's not that I don't want to help.. but I am not sure about which changes and what you are thinking exactly.. so we might have a lot going back and forth discussion.. I suggest to have these changes on other PRs..

@nicolas-grekas
Copy link
Member

phpunit 5 is for php56 😞

I suggest to have these changes on other PRs..

works for me!

-----

* added`ClassExistsMock`
* bumped PHP version from 5.5.3 to 5.5.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is it a typo?5.3.3?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🤦‍♂️... Yes it is a type.. fixed.

@greg0ire
Copy link
Contributor

TheLegacy namespace should stay around for a while, but some simplifications seem indeed possible:https://3v4l.org/MmG7J I'm working on a PR right now.

@fabpotfabpotforce-pushed thebump_php_version_phpunit_bridge branch frome4f7a09 to5931309CompareJanuary 1, 2019 18:14
@fabpot
Copy link
Member

Thank you@gmponos.

@fabpotfabpot merged commit5931309 intosymfony:masterJan 1, 2019
fabpot added a commit that referenced this pull requestJan 1, 2019
…mponos)This PR was squashed before being merged into the 4.3-dev branch (closes#29718).Discussion----------[PHPUnit bridge] Bump php version of PHPUnit-bridge| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no (?)| Deprecations? | no| Tests pass?   | yes| License       | MITRelated to#29623 (comment)I checked the BC page I think I couldn't find any related to BC changes... anyway...As far as I understood from the comment above I must target `master` branch.Commits-------5931309 [PHPUnit bridge] Bump php version of PHPUnit-bridge
@gmponosgmponos deleted the bump_php_version_phpunit_bridge branchJanuary 1, 2019 18:21
nicolas-grekas added a commit that referenced this pull requestJan 27, 2019
…las-grekas)This PR was merged into the 4.3-dev branch.Discussion----------[PHPUnitBridge] Static access in closure| Q             | A| ------------- | ---| Branch?       | master for features| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n / a| License       | MIT| Doc PR        | n / a#29718 bumps php to 5.5 . This is what we could simplify if it gets merged, thanks to this "new" PHP feature:https://3v4l.org/sJOWrEDIT: it was merged, this can be reviewed.Commits-------97f3023 Use the scope of an instance9df76eb Extract closures into static functions
fabpot added a commit that referenced this pull requestApr 12, 2019
… (greg0ire)This PR was merged into the 4.3-dev branch.Discussion----------[PhpUnitBridge] Url encoded deprecations helper config| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#28048| License       | MIT| Doc PR        |symfony/symfony-docs#10701First stab at implementing a new way of configuring the deprecation error handler. Includes a refactoring to keep things manageable.Rework of#24867, blocked by#29718TODO:- [x] make the code 5.5 compatible 😢- [x] add more tests- [x] deprecate modes (using echo :P)- [x] test this on real life projects and add some screenshots- [x] docs PR- [x] handle `strict`- [x] adapt existing CI config# Quiet configuration![quiet](https://user-images.githubusercontent.com/657779/49341318-fa78c900-f64b-11e8-9504-a8a9eac4baf8.png)# Default configuration![verbose](https://user-images.githubusercontent.com/657779/49341322-10868980-f64c-11e8-9d90-dc3f6a18c335.png)Commits-------1c73f9c [PhpUnitBridge] Url encoded deprecations helper config
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gmponos@nicolas-grekas@greg0ire@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp