NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Fixed minor typos in an error message#29711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ogizanagi merged 1 commit intosymfony:4.2fromjaviereguiluz:improve_error

Dec 28, 2018

Merged

Fixed minor typos in an error message#29711

ogizanagi merged 1 commit intosymfony:4.2fromjaviereguiluz:improve_error

Dec 28, 2018

Conversation

Copy link

Member

javiereguiluz commentedDec 28, 2018

Q	A
Branch?	4.2
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

javiereguiluz added the Console label

Dec 28, 2018

javiereguiluz added this to the4.2 milestone

Dec 28, 2018

carsonbot added the Status: Needs Review label

Dec 28, 2018

xabbuh requested changes

Dec 28, 2018

View reviewed changes

src/Symfony/Component/Console/Helper/ProcessHelper.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Dec 28, 2018

javiereguiluz added Status: Reviewed and removed Status: Needs Work labels

Dec 28, 2018

xabbuh approved these changes

Dec 28, 2018

View reviewed changes

OskarStark approved these changes

Dec 28, 2018

View reviewed changes

ogizanagi approved these changes

Dec 28, 2018

View reviewed changes

ogizanagi force-pushed theimprove_error branch from439caff to913fdbeCompare

December 28, 2018 23:07

Fixed minor typos in an error message

913fdbe

Copy link

Contributor

ogizanagi commentedDec 28, 2018

Thanks Javier.

ogizanagi merged commit913fdbe intosymfony:4.2

Dec 28, 2018

ogizanagi added a commit that referenced this pull request

Dec 28, 2018

minor#29711Fixed minor typos in an error message (javiereguiluz)

85b313d

This PR was squashed before being merged into the 4.2 branch (closes#29711).Discussion----------Fixed minor typos in an error message| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | no| New feature?  | no| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | -| License       | MIT| Doc PR        | -Commits-------913fdbe Fixed minor typos in an error message