Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] improve errors in tests missing the BrowserKit component#29704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedDec 27, 2018
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29696 |
| License | MIT |
| Doc PR |
localheinz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
| try { | ||
| $client =$kernel->getContainer()->get('test.client'); | ||
| }catch (ServiceNotFoundException$e) { | ||
| thrownew \LogicException('The BrowserKit component is required to be able to create a client.',$e->getCode(),$e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could we reword this to be similar to other error messages added recently?
thrownew \LogicException('You can not create the client used in functional tests if the BrowserKit component is not available. Try running "composer require symfony/browser-kit".')
fabpot commentedJan 1, 2019
Thank you@xabbuh. |
…serKit component (xabbuh)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] improve errors in tests missing the BrowserKit component| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29696| License | MIT| Doc PR |Commits-------7961a29 improve error message when using test client without the BrowserKit component