Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Add new block_prefix option for an easy form theming#29680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromyceruto:add_block_prefix_option
Jan 3, 2019

Conversation

@yceruto
Copy link
Member

@ycerutoyceruto commentedDec 25, 2018•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29651
LicenseMIT
Doc PRsymfony/symfony-docs#10835

Copy link
Contributor

@HeahDudeHeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Many thanks and merry Christmas <3

@yceruto
Copy link
MemberAuthor

Thank you@HeahDude for your quick review and merry Christmas!

Copy link
Contributor

@vudaltsovvudaltsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great idea, love it!

multiple data
placeholder disabled
preferred_choices help
help_attr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hmpf this table rst layout makes it hard for small and readable diffs, because in this case only one string is changed (added)

@ycerutoycerutoforce-pushed theadd_block_prefix_option branch fromf0d120f tobd50ac4CompareJanuary 2, 2019 01:10
@yceruto
Copy link
MemberAuthor

Doc PR created.

(AppVeyor failure is unrelated)

@fabpot
Copy link
Member

Thank you@yceruto.

@fabpotfabpot merged commitbd50ac4 intosymfony:masterJan 3, 2019
fabpot added a commit that referenced this pull requestJan 3, 2019
…eming (yceruto)This PR was merged into the 4.3-dev branch.Discussion----------[Form] Add new block_prefix option for an easy form theming| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#29651| License       | MIT| Doc PR        |symfony/symfony-docs#10835Commits-------bd50ac4 Add block_prefix option for an easy form theming
@ycerutoyceruto deleted the add_block_prefix_option branchJanuary 3, 2019 15:10
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestJan 22, 2019
This PR was squashed before being merged into the master branch (closes#10835).Discussion----------[Form] Documenting the block_prefix optionDocumenting new feature:symfony/symfony#29680Commits-------d9382d4 [Form] Documenting the block_prefix option
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+2 more reviewers

@HeahDudeHeahDudeHeahDude approved these changes

@vudaltsovvudaltsovvudaltsov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

9 participants

@yceruto@fabpot@javiereguiluz@nicolas-grekas@OskarStark@xabbuh@vudaltsov@HeahDude@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp