Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Correctly Render Signed URIs Containing Fragments#29679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@zanbaldwin
Copy link
Member

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no?
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRn/a
  • Rebuild the URL with the computed hash instead of appending it onto the end of the fragment.
  • Update unit tests, and add new unit test to cover URIs that include fragments.

@zanbaldwinzanbaldwin changed the titleCorrectly Render Signed URIs Containing Fragments[HttpKernel] Correctly Render Signed URIs Containing FragmentsDec 24, 2018
Rebuild the URL with the computed hash instead of appending it onto the end of the URI, preventing incorrect formatting when dealing with URIs containing fragments.
@zanbaldwinzanbaldwinforce-pushed thefeature/uri-signer-fragment branch frome4cfa4e tob9ece6bCompareDecember 24, 2018 13:31
@nicolas-grekasnicolas-grekas added this to the3.4 milestoneDec 24, 2018
@nicolas-grekas
Copy link
Member

Hi Zan, I'm not sure I get what this fixes? From the description, I feel like this is just a different way to achieve the same. Can you give some more hints please? Thanks :)

@zanbaldwin
Copy link
MemberAuthor

zanbaldwin commentedDec 25, 2018•
edited
Loading

Sorry, I should have given an example!
If a URI contained a fragment, the resulting signed URL would have resulted in the hash query parameter appended to the URI string (after the fragment), instead of being placed in the query string part of the URL. For example:

Before:http://example.com/path?foo=bar#fragment&_hash=$HASH

After:http://example.com/path?foo=bar&_hash=$HASH#fragment

@fabpot
Copy link
Member

Thank you@zanbaldwin.

@fabpotfabpot merged commitb9ece6b intosymfony:3.4Jan 5, 2019
fabpot added a commit that referenced this pull requestJan 5, 2019
…ents (zanbaldwin)This PR was merged into the 3.4 branch.Discussion----------[HttpKernel] Correctly Render Signed URIs Containing Fragments| Q             | A| ------------- | ---| Branch?       | `3.4`| Bug fix?      | yes| New feature?  | no| BC breaks?    | no?| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/a- Rebuild the URL with the computed hash instead of appending it onto the end of the fragment.- Update unit tests, and add new unit test to cover URIs that include fragments.Commits-------b9ece6b [HttpKernel] Correctly Render Signed URIs Containing Fragments
This was referencedJan 6, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@zanbaldwin@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp