Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] fix bad optim#29644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Cache] fix bad optim#29644
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedDec 18, 2018
| Q | A |
|---|---|
| Branch? | 4.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29643 |
| License | MIT |
| Doc PR | - |
gerty3000 commentedDec 18, 2018
@nicolas-grekas out of curiosity, could you provide a description why it fixes the thing? |
nicolas-grekas commentedDec 18, 2018
@seclu see what@strider2038 provided in the linked issue#29643. |
| $e =new \Exception(); | ||
| $this->includeHandler =function ()use ($e) {throw$e;}; | ||
| $this->includeHandler =function ($type,$msg,$file,$line) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shouldn't this be a static function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it would be a public one - better not (and would be slower if that matters)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I meant a static anonymous function, i.e just addingstatic in front of the currentfunction keyword, not moving it to a static method. It doesn't affect the visibility does it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
static it is now
Uh oh!
There was an error while loading.Please reload this page.
stof commentedDec 18, 2018
@seclu it does not create an exception with its stack trace in the constructor anymore. the stack trace was the one retaining references to other stuff. |
This PR was merged into the 4.2 branch.Discussion----------[Cache] fix bad optim| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29643| License | MIT| Doc PR | -Commits-------b76d4ea [Cache] fix bad optim