Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixes URI parsing#29631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ian-starts wants to merge1 commit intosymfony:masterfromian-starts:patch-2
Closed

Fixes URI parsing#29631

ian-starts wants to merge1 commit intosymfony:masterfromian-starts:patch-2

Conversation

@ian-starts
Copy link

@ian-startsian-starts commentedDec 17, 2018•
edited
Loading

When $this->server->get('REQUEST_URI'); passes //foo/bar the parse_url function assumes that foo is the host and not part of the path.

QA
Branch?master for features / 3.4 up to 4.2 for bug fixes
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

When $this->server->get('REQUEST_URI'); passes //foo/bar the parse_url function assumes that foo is the host and not part of the path.
@nicolas-grekas
Copy link
Member

Duplicate of#29494? Can you check if it fixes the same issue please?

alquerci reacted with thumbs up emoji

@ian-starts
Copy link
Author

Duplicate of#29494? Can you check if it fixes the same issue please?
Ah you're right! Though I do (obviously) think that my solution is more elegant. But that's just vanity.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedDec 17, 2018•
edited
Loading

think that my solution is more elegant

(See broken tests.)
It would if it were to work - and had new tests ;)
Just kidding.

Thanks for submitting.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ian-starts@nicolas-grekas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp