Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Prefer clone() over unserialize(serialize()) for user refreshment#29621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Using clone was discussed in#28072 (comment)
but here this php bug gives us no other choices.
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I confirm that this fix solved the error for me. Thanks!
nicolas-grekas commentedDec 17, 2018
Thank you@chalasr. |
…r user refreshment (chalasr)This PR was merged into the 3.4 branch.Discussion----------[Security] Prefer clone() over unserialize(serialize()) for user refreshment| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29459| License | MIT| Doc PR | n/aTo not hit the `serialize()` bug reported in the related ticketCommits-------a8eba80 [Security] Prefer clone over unserialize(serialize()) for user refreshment
To not hit the
serialize()bug reported in the related ticket