Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] OutputFormatter: move strtolower to createStyleFromString#29619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromogizanagi:console/output_formatter/move_strtolowerDec 17, 2018
Merged
[Console] OutputFormatter: move strtolower to createStyleFromString#29619
nicolas-grekas merged 1 commit intosymfony:3.4fromogizanagi:console/output_formatter/move_strtolowerDec 17, 2018
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
While playing with the href feature that'll be available in 4.3,I spotted href value is lowercased. Which I guess could be an issueon case-sensitive filesystems.This changes nothing for the current branch, but will allow when mergingto upper branches to fix the behavior described above, hence keep original case.
nicolas-grekas approved these changesDec 15, 2018
chalasr approved these changesDec 15, 2018
ostrolucky approved these changesDec 15, 2018
Contributor
ostrolucky left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good find!
Member
nicolas-grekas commentedDec 17, 2018
Thank you@ogizanagi. |
nicolas-grekas added a commit that referenced this pull requestDec 17, 2018
…romString (ogizanagi)This PR was merged into the 3.4 branch.Discussion----------[Console] OutputFormatter: move strtolower to createStyleFromString| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | not really| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/AWhile playing with the href feature that'll be available in 4.3,I spotted href value [is lowercased](#29620). Which I guess could be an issue on case-sensitive filesystems.This changes nothing for the current branch, but will allow when mergingto upper branches to fix the behavior described above, hence keep original case.Commits-------8e2bd35 [Console] OutputFormatter: move strtolower to createStyleFromString
symfony-splitter pushed a commit to symfony/console that referenced this pull requestDec 17, 2018
This PR was merged into the 4.3-dev branch.Discussion----------[Console] Test href case conservation| Q | A| ------------- | ---| Branch? | master <!-- see below -->| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | no <!-- please add some, will be required by reviewers -->| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/AExpecting this test to fail untilsymfony/symfony#29619 is merged up.Commits-------2b55d1504e [Console] Test href case conservation
nicolas-grekas added a commit that referenced this pull requestDec 17, 2018
This PR was merged into the 4.3-dev branch.Discussion----------[Console] Test href case conservation| Q | A| ------------- | ---| Branch? | master <!-- see below -->| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | no <!-- please add some, will be required by reviewers -->| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/AExpecting this test to fail until#29619 is merged up.Commits-------2b55d15 [Console] Test href case conservation
This was referencedJan 6, 2019
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
While playing with the href feature that'll be available in 4.3,
I spotted href valueis lowercased. Which I guess could be an issue on case-sensitive filesystems.
This changes nothing for the current branch, but will allow when merging
to upper branches to fix the behavior described above, hence keep original case.