Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Fix undefined variable in ArrayTrait#29591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.2fromeXtreme:fix_cache_issue
Dec 13, 2018

Conversation

@eXtreme
Copy link
Contributor

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

After upgrading my project to 4.2 my tests failed with a message that$key variable is missing here:

CacheItem::log($this->logger,'Failed to save key "{key}" ({type})',array('key' =>$key,'type' =>$type,'exception' =>$e));
which seems to be introduced with PR#27563.

So I added that variable to the trait and method calls (are there any other?). This is internal class so I guess noone is using it anywhere.

Anyway, my tests pass with this fix.

@nicolas-grekas
Copy link
Member

Thank you@eXtreme.

@nicolas-grekasnicolas-grekas merged commitb0b5937 intosymfony:4.2Dec 13, 2018
nicolas-grekas added a commit that referenced this pull requestDec 13, 2018
This PR was merged into the 4.2 branch.Discussion----------[Cache] Fix undefined variable in ArrayTrait| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |After upgrading my project to 4.2 my tests failed with a message that `$key` variable is missing here:https://github.com/symfony/symfony/blob/e81285249b780a11ed209a79fa77c1f6ea6da67b/src/Symfony/Component/Cache/Traits/ArrayTrait.php#L131 which seems to be introduced with PR#27563.So I added that variable to the trait and method calls (are there any other?). This is internal class so I guess noone is using it anywhere.Anyway, my tests pass with this fix.Commits-------b0b5937 Fix undefined variable in cache ArrayTrait
@eXtremeeXtreme deleted the fix_cache_issue branchDecember 13, 2018 13:39
@fabpotfabpot mentioned this pull requestJan 6, 2019
nicolas-grekas added a commit that referenced this pull requestJun 5, 2019
This PR was squashed before being merged into the 4.3 branch (closes#31864).Discussion----------[Cache] Fixed undefined variable in ArrayTrait| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |So once again (see#29591) my test suite managed to find an error in ArrayTrait in cache. This time it was this PR:#31395 later improved by#31590 that introduced `$id` to logging, which I guess should be `$key`? So this PR changes it to `$key`, ~but my tests **still fail** as there is no `$this->namespace` in `ArrayAdapter` (is this the only class that uses this ArrayTrait?). But I don't know what to do about it. Maybe@nicolas-grekas has some answers?~Commits-------8568923 [Cache] Fixed undefined variable in ArrayTrait
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

3 participants

@eXtreme@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp