Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] add margin-bottom to caption#2957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedDec 26, 2011
What does it fix? |
havvg commentedDec 27, 2011
Just a minor design issue with table captions. Without:http://dl.dropbox.com/u/548684/PR2957/without-margin.png I currently hold it in a custom css, but thought it is generic enough to be put into the bundle. |
henrikbjorn commentedDec 27, 2011
@havvg What custom bundle is that ? and what does it show? look interesting |
havvg commentedDec 27, 2011
@henrikbjorn It's a bundle (not published yet,https://github.com/havvg/HavvgCloudcontrolBundle) adding features to fully utilize applications onhttp://cloudcontrol.com PaaS. |
Commits-------41950a6 [WebProfilerBundle] add margin-bottom to captionDiscussion----------[WebProfilerBundle] add margin-bottom to caption---------------------------------------------------------------------------by fabpot at 2011/12/26 13:15:57 -0800What does it fix?---------------------------------------------------------------------------by havvg at 2011/12/27 02:46:16 -0800Just a minor design issue with table captions.Without:http://dl.dropbox.com/u/548684/PR2957/without-margin.pngWith:http://dl.dropbox.com/u/548684/PR2957/with-margin.pngI currently hold it in a custom css, but thought it is generic enough to be put into the bundle.---------------------------------------------------------------------------by henrikbjorn at 2011/12/27 04:03:53 -0800@havvg What custom bundle is that ? and what does it show? look interesting---------------------------------------------------------------------------by havvg at 2011/12/27 04:40:18 -0800@henrikbjorn It's a bundle (not published yet,https://github.com/havvg/HavvgCloudcontrolBundle) adding features to fully utilize applications onhttp://cloudcontrol.com PaaS.
Insymfony#29853 the bugfix made insymfony#29597 was reverted as it did not work asexpected. This fixture file has been modified after the 3.4 branch wasmerged up to account for the changes made insymfony#2957 and must now bereverted to the former state too.
…abbuh)This PR was merged into the 4.2 branch.Discussion----------[DependencyInjection] fix test after revert of bugfix| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |In#29853 the bugfix made in#29597 was reverted as it did not work asexpected. This fixture file has been modified after the 3.4 branch wasmerged up to account for the changes made in#2957 and must now bereverted to the former state too.Commits-------81f63b1 fix test after revert of bugfix
No description provided.