Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfilerBundle] add margin-bottom to caption#2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.0fromhavvg:patch-1
Dec 28, 2011

Conversation

@havvg
Copy link
Contributor

No description provided.

@fabpot
Copy link
Member

What does it fix?

@havvg
Copy link
ContributorAuthor

Just a minor design issue with table captions.

Without:http://dl.dropbox.com/u/548684/PR2957/without-margin.png
With:http://dl.dropbox.com/u/548684/PR2957/with-margin.png

I currently hold it in a custom css, but thought it is generic enough to be put into the bundle.

@henrikbjorn
Copy link
Contributor

@havvg What custom bundle is that ? and what does it show? look interesting

@havvg
Copy link
ContributorAuthor

@henrikbjorn It's a bundle (not published yet,https://github.com/havvg/HavvgCloudcontrolBundle) adding features to fully utilize applications onhttp://cloudcontrol.com PaaS.

fabpot added a commit that referenced this pull requestDec 28, 2011
Commits-------41950a6 [WebProfilerBundle] add margin-bottom to captionDiscussion----------[WebProfilerBundle] add margin-bottom to caption---------------------------------------------------------------------------by fabpot at 2011/12/26 13:15:57 -0800What does it fix?---------------------------------------------------------------------------by havvg at 2011/12/27 02:46:16 -0800Just a minor design issue with table captions.Without:http://dl.dropbox.com/u/548684/PR2957/without-margin.pngWith:http://dl.dropbox.com/u/548684/PR2957/with-margin.pngI currently hold it in a custom css, but thought it is generic enough to be put into the bundle.---------------------------------------------------------------------------by henrikbjorn at 2011/12/27 04:03:53 -0800@havvg What custom bundle is that ? and what does it show? look interesting---------------------------------------------------------------------------by havvg at 2011/12/27 04:40:18 -0800@henrikbjorn It's a bundle (not published yet,https://github.com/havvg/HavvgCloudcontrolBundle) adding features to fully utilize applications onhttp://cloudcontrol.com PaaS.
@fabpotfabpot merged commit41950a6 intosymfony:2.0Dec 28, 2011
xabbuh added a commit to xabbuh/symfony that referenced this pull requestJan 14, 2019
Insymfony#29853 the bugfix made insymfony#29597 was reverted as it did not work asexpected. This fixture file has been modified after the 3.4 branch wasmerged up to account for the changes made insymfony#2957 and must now bereverted to the former state too.
fabpot added a commit that referenced this pull requestJan 15, 2019
…abbuh)This PR was merged into the 4.2 branch.Discussion----------[DependencyInjection] fix test after revert of bugfix| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |In#29853 the bugfix made in#29597 was reverted as it did not work asexpected. This fixture file has been modified after the 3.4 branch wasmerged up to account for the changes made in#2957 and must now bereverted to the former state too.Commits-------81f63b1 fix test after revert of bugfix
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@havvg@fabpot@henrikbjorn

[8]ページ先頭

©2009-2025 Movatter.jp