TheHandlersLocator introduced in 4.2 currently needs to instantiate all message handlers of the bus in order to be wired, while they were lazily loaded in 4.1 via ContainerHandlerLocator (removed).

Example:

framework:messenger:buses:messenger.bus.command:~services:App\Messenger\:resource:'../src/Messenger/*Handler.php'tags:            -{ name: messenger.message_handler, bus: messenger.bus.command }

namespaceApp\Messenger;class BarCommand {}class BarCommandHandler {publicfunction__invoke(BarCommand$command):void {} }class FooCommand {}class FooCommandHandler {publicfunction__invoke(FooCommand$command):void {} }

(DumpedHandleMessageMiddleware factory) Before:

return$this->privates['messenger.bus.command.middleware.handle_message'] =new \Symfony\Component\Messenger\Middleware\HandleMessageMiddleware(new \Symfony\Component\Messenger\Handler\HandlersLocator(array('App\\Messenger\\BarCommand' =>\current(array(0 =>array(0 =>new \App\Messenger\BarCommandHandler()))),'App\\Messenger\\FooCommand' =>\current(array(0 =>array(0 =>new \App\Messenger\FooCommandHandler()))))));

After:

return$this->privates['messenger.bus.command.middleware.handle_message'] =new \Symfony\Component\Messenger\Middleware\HandleMessageMiddleware(new \Symfony\Component\Messenger\Handler\HandlersLocator(array('App\\Messenger\\BarCommand' =>newRewindableGenerator(function () {yield0 => ($this->privates['App\Messenger\BarCommandHandler'] ?? ($this->privates['App\Messenger\BarCommandHandler'] =new \App\Messenger\BarCommandHandler()));    },1),'App\\Messenger\\FooCommand' =>newRewindableGenerator(function () {yield0 => ($this->privates['App\Messenger\FooCommandHandler'] ?? ($this->privates['App\Messenger\FooCommandHandler'] =new \App\Messenger\FooCommandHandler()));    },1))));

chalasr added Bug Messenger labels

Dec 10, 2018

chalasr added this to the4.2 milestone

Dec 10, 2018

carsonbot added the Status: Needs Review label

Dec 10, 2018

chalasr force-pushed thelazy-handler-map branch from0acdfd6 to879d73eCompare

December 10, 2018 21:54

nicolas-grekas approved these changes

Dec 11, 2018

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(SendersLocator is fine?)

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Dec 11, 2018

ogizanagi approved these changes

Dec 11, 2018

View reviewed changes

fabpot changed the title~~[Messenger] Restaure message handlers laziness~~[Messenger] Restore message handlers laziness

Dec 11, 2018

chalasr force-pushed thelazy-handler-map branch 2 times, most recently from88ef942 to1d7455bCompare

December 11, 2018 10:08

Copy link

MemberAuthor

chalasr commentedDec 11, 2018

@nicolas-grekas it looked fine, but updated for consistency and simplicity.

[Messenger] Restore message handlers laziness

c608e73

chalasr force-pushed thelazy-handler-map branch from1d7455b toc608e73Compare

December 11, 2018 22:34

Copy link

Member

nicolas-grekas commentedDec 13, 2018

Thank you@chalasr.

nicolas-grekas merged commitc608e73 intosymfony:4.2

Dec 13, 2018

nicolas-grekas added a commit that referenced this pull request

Dec 13, 2018

bug#29558[Messenger] Restore message handlers laziness (chalasr)

0b99a8e

This PR was merged into the 4.2 branch.Discussion----------[Messenger] Restore message handlers laziness| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aThe `HandlersLocator` introduced in 4.2 currently needs to instantiate all message handlers of the bus in order to be wired, while they were lazily loaded in 4.1 via ContainerHandlerLocator (removed).Example:```yamlframework:    messenger:        buses:            messenger.bus.command: ~services:    App\Messenger\:        resource: '../src/Messenger/*Handler.php'        tags:            - { name: messenger.message_handler, bus: messenger.bus.command }``````phpnamespace App\Messenger;class BarCommand {}class BarCommandHandler { public function __invoke(BarCommand $command): void {} }class FooCommand {}class FooCommandHandler { public function __invoke(FooCommand $command): void {} }```(Dumped `HandleMessageMiddleware` factory) Before:```phpreturn $this->privates['messenger.bus.command.middleware.handle_message'] = new \Symfony\Component\Messenger\Middleware\HandleMessageMiddleware(new \Symfony\Component\Messenger\Handler\HandlersLocator(array(    'App\\Messenger\\BarCommand' => \current(array(0 => array(0 => new \App\Messenger\BarCommandHandler()))),    'App\\Messenger\\FooCommand' => \current(array(0 => array(0 => new \App\Messenger\FooCommandHandler()))))));```After:```phpreturn $this->privates['messenger.bus.command.middleware.handle_message'] = new \Symfony\Component\Messenger\Middleware\HandleMessageMiddleware(new \Symfony\Component\Messenger\Handler\HandlersLocator(array(    'App\\Messenger\\BarCommand' => new RewindableGenerator(function () {        yield 0 => ($this->privates['App\Messenger\BarCommandHandler'] ?? ($this->privates['App\Messenger\BarCommandHandler'] = new \App\Messenger\BarCommandHandler()));    }, 1),    'App\\Messenger\\FooCommand' => new RewindableGenerator(function () {        yield 0 => ($this->privates['App\Messenger\FooCommandHandler'] ?? ($this->privates['App\Messenger\FooCommandHandler'] = new \App\Messenger\FooCommandHandler()));    }, 1))));```Commits-------c608e73 [Messenger] Restore message handlers laziness

chalasr deleted the lazy-handler-map branch

December 13, 2018 09:13

fabpot mentioned this pull request

Jan 6, 2019

Release v4.2.2#29803

Merged