Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] Add colors to workflow dumps#29538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alexislefebvre
Copy link
Contributor

@alexislefebvrealexislefebvre commentedDec 9, 2018•
edited
Loading

Fixes#28874

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28874, replaces#28933
LicenseMIT
Doc PRTODO, requiressymfony/symfony-docs#9476

Fetch data with theMetadataStore from#26092 in order to add colors to the dumps.

Example of configuration:

transitions:submit:from:startto:travismetadata:title:transition submit titledump_style:label:'My custom label'arrow_color:'#0088FF'label_color:'Red'

This code was developed as a bundle, examples can be found on its repository:https://github.com/alexislefebvre/SymfonyWorkflowStyleBundle

HeahDude, andreybolonin, and sylvaindeloux reacted with heart emoji
@alexislefebvrealexislefebvre changed the titleAdd colors to workflow dumps[Workflow] Add colors to workflow dumpsDec 9, 2018
@nicolas-grekasnicolas-grekas added this to thenext milestoneDec 9, 2018
Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I did not tested it, but It's a very good start

@alexislefebvre
Copy link
ContributorAuthor

The last two examples onthis page shows the dot format, withmultiple_state, transitions are displayed as square instead of arrows with texts.

So the optionbackground_color is used instead ofarrow_color because it's meaningless in this context. I still have to find a limited number of parameters that would allow styling states and transitions with state machines and workflows.

@alexislefebvrealexislefebvreforce-pushed the28874-add-colors-to-workflow-dumps-2 branch from03eb8fe to31e9564CompareDecember 15, 2018 00:53
@alexislefebvre
Copy link
ContributorAuthor

Can someone please remove theDeprecation tag? I forgot to change the value when creating the PR.

@alexislefebvrealexislefebvreforce-pushed the28874-add-colors-to-workflow-dumps-2 branch from31e9564 to0b54bcbCompareDecember 30, 2018 16:36
@nicolas-grekas
Copy link
Member

rebase needed due to short arrays.

@alexislefebvrealexislefebvreforce-pushed the28874-add-colors-to-workflow-dumps-2 branch 6 times, most recently from4698c38 toebe5385CompareFebruary 5, 2019 00:57
@alexislefebvre
Copy link
ContributorAuthor

Thanks for hint, the PR has been rebased.

@fabpot
Copy link
Member

@lyrixx I think we need your help to move forward here.

Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

alexislefebvre reacted with heart emoji
@lyrixx
Copy link
Member

lyrixx commentedMar 13, 2019•
edited
Loading

Thanks@alexislefebvre . This is very Good. Could you rebase before the merge ? (I think this will conflict with#30468 but I will take care of it).

Could someone review English textes (PHP Doc, Changelog)? 🙏 Thanks

@alexislefebvrealexislefebvreforce-pushed the28874-add-colors-to-workflow-dumps-2 branch fromebe5385 toe12babfCompareMarch 13, 2019 21:57
@alexislefebvre
Copy link
ContributorAuthor

Rebase done. ✔️

Thanks for the follow-up.

@alexislefebvrealexislefebvreforce-pushed the28874-add-colors-to-workflow-dumps-2 branch from84a0553 to4d313e5CompareMarch 17, 2019 22:57
@alexislefebvrealexislefebvreforce-pushed the28874-add-colors-to-workflow-dumps-2 branch from4d313e5 to0a59b50CompareMarch 18, 2019 21:30
@fabpotfabpotforce-pushed the28874-add-colors-to-workflow-dumps-2 branch from0a59b50 to60ad109CompareMarch 19, 2019 05:09
@fabpot
Copy link
Member

Thank you@alexislefebvre.

alexislefebvre reacted with thumbs up emojialexislefebvre reacted with hooray emoji

@fabpotfabpot merged commit60ad109 intosymfony:masterMar 19, 2019
fabpot added a commit that referenced this pull requestMar 19, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes#29538).Discussion----------[Workflow] Add colors to workflow dumpsFixes#28874| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28874, replaces#28933| License       | MIT| Doc PR        | TODO, requiressymfony/symfony-docs#9476Fetch data with the `MetadataStore` from#26092 in order to add colors to the dumps.Example of configuration:```yaml            transitions:                submit:                    from: start                    to: travis                    metadata:                        title: transition submit title                        dump_style:                            label: 'My custom label'                            arrow_color: '#0088FF'                            label_color: 'Red'```This code was developed as a bundle, examples can be found on its repository:https://github.com/alexislefebvre/SymfonyWorkflowStyleBundleCommits-------60ad109 [Workflow] Add colors to workflow dumps
@alexislefebvrealexislefebvre deleted the 28874-add-colors-to-workflow-dumps-2 branchMarch 19, 2019 09:44
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
fabpot added a commit that referenced this pull requestJul 8, 2019
…n (alexislefebvre)This PR was submitted for the 4.4 branch but it was merged into the 4.3 branch instead (closes#32419).Discussion----------[Workflow] Add missing test for workflow dump description| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |This PR add a test for a feature added in#29538 but missed a test.Commits-------0c326d0 Add missing test for workflow dump description
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestJul 8, 2019
…alexislefebvre)This PR was merged into the 4.3 branch.Discussion----------[Workflow] Explain how to style a workflow dumpFixessymfony#11675Explain what was added insymfony/symfony#29538TODO:- [x] Explain keys- [x] Add YAML format- [x] Add XML format- [x] Add PHP formatCommits-------e6c1992 Workflow: explain how to style a workflow dump
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@lyrixxlyrixxlyrixx approved these changes

+3 more reviewers

@ro0NLro0NLro0NL left review comments

@noniagriconomienoniagriconomienoniagriconomie left review comments

@KronhyxKronhyxKronhyx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

[Workflow] Add colors to workflow dumps

9 participants

@alexislefebvre@nicolas-grekas@fabpot@lyrixx@javiereguiluz@ro0NL@noniagriconomie@Kronhyx@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp