Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Added IBAN format for Vatican City State#29531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromraulfraile:feature/iban-vatican-city
Dec 9, 2018

Conversation

@raulfraile
Copy link
Contributor

IBAN for Vatican City State was added toIBAN registry recently. This PR adds support for this new format in theIban validator.

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
LicenseMIT

@ostrolucky
Copy link
Contributor

I think patches like these are treated as bugfixes, so should be targetting 3.4

ro0NL reacted with thumbs up emoji

-----

* added options`iban` and`ibanPropertyPath` to Bic constraint
* added support for Vatican City State IBAN format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should be removed when rebased on 3.4 (as this should indeed be considered as a bug fix).

@raulfraileraulfraile changed the base branch frommaster to3.4December 9, 2018 09:02
@raulfraileraulfraile changed the base branch from3.4 tomasterDecember 9, 2018 09:02
@raulfraileraulfraileforce-pushed thefeature/iban-vatican-city branch from2374ce9 tod169bf0CompareDecember 9, 2018 09:55
@raulfraileraulfraile changed the base branch frommaster to3.4December 9, 2018 09:56
@raulfraile
Copy link
ContributorAuthor

@fabpot thanks for the comments! It's now rebased and targetting3.4

@fabpotfabpotforce-pushed thefeature/iban-vatican-city branch from7826734 to5f02614CompareDecember 9, 2018 10:02
@fabpot
Copy link
Member

Thank you@raulfraile.

@fabpotfabpot merged commit5f02614 intosymfony:3.4Dec 9, 2018
fabpot added a commit that referenced this pull requestDec 9, 2018
…fraile)This PR was squashed before being merged into the 3.4 branch (closes#29531).Discussion----------[Validator] Added IBAN format for Vatican City StateIBAN for Vatican City State was added to [IBAN registry](https://www.swift.com/sites/default/files/resources/iban_registry.pdf) recently. This PR adds support for this new format in the `Iban` validator.| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MITCommits-------5f02614 [Validator] Added IBAN format for Vatican City State
This was referencedJan 6, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raulfraile@ostrolucky@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp