Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBridge][Form] Prevent multiple rendering of form collection prototypes#29527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
xabbuh approved these changesDec 8, 2018
Member
nicolas-grekas commentedDec 8, 2018
Please update the PR + commit titles to a standalone self-describing and short one. Please also add the target component in square brackets. |
HeahDude approved these changesDec 12, 2018
Member
nicolas-grekas commentedDec 12, 2018
Thank you@Shoplifter. |
nicolas-grekas added a commit that referenced this pull requestDec 12, 2018
…ection prototypes (Shoplifter)This PR was merged into the 3.4 branch.Discussion----------[TwigBridge][Form] Prevent multiple rendering of form collection prototypes| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#29489 <!-- #-prefixed issue number(s), if any -->| License | MITprevents attemt to render of prototype in CollectionType when it has been rendered already.(see [Deprecated calling FormRenderer::searchAndRenderBlock for fields which were already rendered.](https://github.com/symfony/symfony/blob/master/UPGRADE-4.2.md#form))Commits-------ffd2722 [TwigBridge][Form] Prevent multiple rendering of form collection prototypes
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevents attemt to render of prototype in CollectionType when it has been rendered already.
(seeDeprecated calling FormRenderer::searchAndRenderBlock for fields which were already rendered.)