NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument#29513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:3.4fromkarser:3.4-deserialize-nested-array-of-objects-bug

Dec 10, 2018

Merged

[Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument#29513

fabpot merged 1 commit intosymfony:3.4fromkarser:3.4-deserialize-nested-array-of-objects-bug

Dec 10, 2018

Conversation

Copy link

Contributor

karser commentedDec 8, 2018•
edited
Loading

Q	A
Branch?	3.4 and up to 4.2
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#28825
License	MIT

This is a fix of#28825 big thanks@dunglas and@xabbuh

carsonbot added Status: Needs Review Serializer Bug labels

Dec 8, 2018

xabbuh mentioned this pull request

Dec 8, 2018

please remove this PR#29507

Closed

Copy link

Member

stof commentedDec 8, 2018

#SymfonyConHackday2018

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Dec 8, 2018

dunglas approved these changes

Dec 8, 2018

View reviewed changes

chalasr added this to the3.4 milestone

Dec 9, 2018

fabpot approved these changes

Dec 10, 2018

View reviewed changes

[Hackday][Serializer] Deserialization ignores argument type hint from…

8741d00

… phpdoc for array in constructor argument

fabpot force-pushed the3.4-deserialize-nested-array-of-objects-bug branch fromf552109 to8741d00Compare

December 10, 2018 03:34

Copy link

Member

fabpot commentedDec 10, 2018

Thank you@karser.

fabpot merged commit8741d00 intosymfony:3.4

Dec 10, 2018

fabpot added a commit that referenced this pull request

Dec 10, 2018

bug#29513[Hackday][Serializer] Deserialization ignores argument typ…

326ebaa

…e hint from phpdoc for array in constructor argument (karser)This PR was squashed before being merged into the 3.4 branch (closes#29513).Discussion----------[Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument| Q             | A| ------------- | ---| Branch?       | 3.4 and up to 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28825| License       | MITThis is a fix of#28825 big thanks@dunglas and@xabbuhCommits-------8741d00 [Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument