Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] Move code from ValidateWorkflowsPass to the FrameworkExtension#29457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lyrixx merged 1 commit intosymfony:masterfromlyrixx:workflow-validation
Mar 13, 2019

Conversation

@lyrixx
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Just some cleaning. See
#29146 (comment)

xabbuh
xabbuh previously requested changesDec 4, 2018
@lyrixxlyrixxforce-pushed theworkflow-validation branch 2 times, most recently from378c4f9 to7c4afd4CompareDecember 5, 2018 07:49
@nicolas-grekasnicolas-grekas added this to thenext milestoneDec 6, 2018
@stof
Copy link
Member

stof commentedDec 7, 2018

The compiler pass should be deprecated, not removed. It don't think making such BC break is actually worth it compared to the deprecation path.

@lyrixx
Copy link
MemberAuthor

lyrixx commentedDec 7, 2018•
edited
Loading

Okay, Il will deprecate it.

@lyrixx
Copy link
MemberAuthor

Hi. I rebased and finished this PR. I put back the ValidateWorkflowsPass but I deprecate it.
I think it's OK now

@lyrixx
Copy link
MemberAuthor

@stof@xabbuh Are you OK with this one? Could I merge it?

@lyrixxlyrixx merged commita608797 intosymfony:masterMar 13, 2019
lyrixx added a commit that referenced this pull requestMar 13, 2019
…rameworkExtension (lyrixx)This PR was merged into the 4.3-dev branch.Discussion----------[Workflow] Move code from ValidateWorkflowsPass to the FrameworkExtension| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |---Just some cleaning. See#29146 (comment)Commits-------a608797 [Workflow] Move code from ValidateWorkflowsPass to the FrameworkExtension
@lyrixxlyrixx deleted the workflow-validation branchMarch 22, 2019 15:14
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh left review comments

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@lyrixx@stof@xabbuh@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp