Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Workflow] Fixed BC break for Workflow metadata#29444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedDec 3, 2018
Thank you@lyrixx. |
This PR was merged into the 4.1 branch.Discussion----------[Workflow] Fixed BC break for Workflow metadata| Q | A| ------------- | ---| Branch? | 4.1| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29427| License | MIT| Doc PR |I used SplObjectStorage to store the transition metadata.So we need to use the exact same PHP Object.Commits-------5691818 [Workflow] Fixed BC break for Workflow metadata
| $this->assertInstanceOf(Definition::class,$params[0]); | ||
| $this->assertSame(Workflow\Transition::class,$params[0]->getClass()); | ||
| $this->assertSame(array('submit','start','travis'),$params[0]->getArguments()); | ||
| $this->assertSame(array('title' =>'transition submit title'),$params[1]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we keep the test ofarray('title' => 'transition submit title')?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No. It's not an instance of transition anymore
I used SplObjectStorage to store the transition metadata.
So we need to use the exact same PHP Object.