Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Fixed Memcached adapter doClear()to call flush()#29436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedDec 3, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Flushing clears completely the Memcache server, while clear should only affect the very items that are in one logical pool (ie same key prefix). Invalidation works already by using an incrementing version number as prefix. |
raitocz commentedDec 3, 2018
@nicolas-grekas But if you pass option to not use versioning? $adapter =newMemcachedAdapter($client,$namespace);$adapter->enableVersioning(false); |
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
To be merged on 3.4. If you want to rebase+retarget please do, otherwise we can do it while merging.
raitocz commentedDec 6, 2018
@nicolas-grekas How long it will take before it gets merged? Thx |
nicolas-grekas commentedDec 6, 2018
Thank you@raitocz. |
…raitocz)This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes#29436).Discussion----------[Cache] Fixed Memcached adapter doClear()to call flush()| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29435| License | MIT| Doc PR | symfony/symfony-docsMemcachedTrait now calls Memcached::flush via its client instead of just returning false.Commits-------447baac [Cache] Fixed Memcached adapter doClear()to call flush()
MemcachedTrait now calls Memcached::flush via its client instead of just returning false.