Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle][Messenger] Restore check for messenger serializer default id#29395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.2fromogizanagi:fix/fwb-messenger-default-serializer
Dec 1, 2018
Merged

[FrameworkBundle][Messenger] Restore check for messenger serializer default id#29395

nicolas-grekas merged 1 commit intosymfony:4.2fromogizanagi:fix/fwb-messenger-default-serializer
Dec 1, 2018

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagiogizanagi commentedNov 30, 2018
edited
Loading

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketshttps://symfony-devs.slack.com/archives/C9PQ75TV3/p1543590611003500
LicenseMIT
Doc PRN/A

From Slack:

@adamquaile [4:10 PM]
So, I just updated to 4.2 today, and got this message:

The default Messenger serializer cannot be enabled as the Serializer support is not available. Try enabling it or running "composer require symfony/serializer-pack"

In the docs it's stated:

In order to use Symfony's built-in AMQP transport, you will need the Serializer Component. Ensure that it is installed with:

But I haven't yet configured AMQP - I'm using my own transport. Should I be getting this exception?


This check was removed in#28405, but is actually still necessary to not fail as soon as you can install the Messenger component without the Serializer one installed.

adamquaile reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

Thank you@ogizanagi.

@nicolas-grekasnicolas-grekas merged commit1cf17c0 intosymfony:4.2Dec 1, 2018
nicolas-grekas added a commit that referenced this pull requestDec 1, 2018
…erializer default id (ogizanagi)This PR was merged into the 4.2 branch.Discussion----------[FrameworkBundle][Messenger] Restore check for messenger serializer default id| Q             | A| ------------- | ---| Branch?       | 4.2 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |https://symfony-devs.slack.com/archives/C9PQ75TV3/p1543590611003500  <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/AFrom Slack:>@adamquaile [4:10 PM]> So, I just updated to 4.2 today, and got this message:> > The default Messenger serializer cannot be enabled as the Serializer support is not available. Try enabling it or running "composer require symfony/serializer-pack">> In the docs it's stated:> > In order to use Symfony's built-in AMQP transport, you will need the Serializer Component. Ensure that it is installed with:>>But I haven't yet configured AMQP - I'm using my own transport. Should I be getting this exception?---This check was removed in#28405, but is actually still necessary to not fail as soon as you can install the Messenger component without the Serializer one installed.Commits-------1cf17c0 [FrameworkBundle][Messenger] Restore check for messenger serializer default id
@ogizanagiogizanagi deleted the fix/fwb-messenger-default-serializer branchDecember 1, 2018 08:12
@fabpotfabpot mentioned this pull requestDec 6, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@ogizanagi@nicolas-grekas@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp