Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Routing] fix trailing slash redirection#29373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.1fromnicolas-grekas:route-fix
Nov 29, 2018

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?4.1
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29363
LicenseMIT
Doc PR-

soukicz reacted with thumbs up emoji
@nicolas-grekasnicolas-grekas added this to the4.1 milestoneNov 29, 2018
@nicolas-grekasnicolas-grekas merged commitfbaba23 intosymfony:4.1Nov 29, 2018
nicolas-grekas added a commit that referenced this pull requestNov 29, 2018
This PR was merged into the 4.1 branch.Discussion----------[Routing] fix trailing slash redirection| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#29363| License       | MIT| Doc PR        | -Commits-------fbaba23 [Routing] fix trailing slash redirection
@nicolas-grekasnicolas-grekas deleted the route-fix branchNovember 29, 2018 15:13
@jimmycleuren
Copy link

Hm, this does not seem to fix the issue for me.

Btw, what is the easiest/best way to check this ? I manually copy/pasted your changes in my vendor folder now.

@nicolas-grekas
Copy link
MemberAuthor

Now that it's merged, you can require~4.1@dev I think. Copy/pasting in vendor works also.
About your issue, without a reproducer, I'm can't to anything I'm afraid.
I think you have a route earlier in the list that takes precedence. Is it legit or not? I can't tell without having it :)

@rodrigonull
Copy link

I don't know if is the same issue, but I have a problem with the route /{id}/

The route matches but the id parameter value is appended with the '/'.

For example /1/ . The id value should be "1" but i get "1/"

This problem began with version 4.1.8 and with this patch the problem remains.

@nicolas-grekas
Copy link
MemberAuthor

any reproducer?

@jimmycleuren
Copy link

I've created a demo app to reproduce the issue. If you try to access /user/ or /admin/, you'll get the error while those routes are ok according to debug:router.

https://github.com/jimmycleuren/routing-issue

@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedNov 30, 2018
edited
Loading

@jimmycleuren thanks understood, I'm on it (#29380 fixes it but is still not finished)

This was referencedNov 30, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@jimmycleuren@rodrigonull@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp