Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Routing] fix trailing slash redirection#29373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedNov 29, 2018
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29363 |
| License | MIT |
| Doc PR | - |
This PR was merged into the 4.1 branch.Discussion----------[Routing] fix trailing slash redirection| Q | A| ------------- | ---| Branch? | 4.1| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29363| License | MIT| Doc PR | -Commits-------fbaba23 [Routing] fix trailing slash redirection
jimmycleuren commentedNov 29, 2018
Hm, this does not seem to fix the issue for me. Btw, what is the easiest/best way to check this ? I manually copy/pasted your changes in my vendor folder now. |
nicolas-grekas commentedNov 29, 2018
Now that it's merged, you can require |
rodrigonull commentedNov 29, 2018
I don't know if is the same issue, but I have a problem with the route /{id}/ The route matches but the id parameter value is appended with the '/'. For example /1/ . The id value should be "1" but i get "1/" This problem began with version 4.1.8 and with this patch the problem remains. |
nicolas-grekas commentedNov 29, 2018
any reproducer? |
jimmycleuren commentedNov 29, 2018
I've created a demo app to reproduce the issue. If you try to access /user/ or /admin/, you'll get the error while those routes are ok according to debug:router. |
nicolas-grekas commentedNov 30, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@jimmycleuren thanks understood, I'm on it (#29380 fixes it but is still not finished) |