Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] fix combinatorial explosion when analyzing the service graph#29369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…e graph (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[DI] fix combinatorial explosion when analyzing the service graph| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29336| License | MIT| Doc PR | -and a few minor things found meanwhile.Commits-------0d0be12 [DI] fix combinatorial explosion when analyzing the service graph
alexander-schranz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@nicolas-grekas thank you! The performance is now again near the 4.1.7 version:
Current benchmark:
v4.1.7:8,85s user 1,02s system 98% cpu 9,987 total
v4.1.8:68,62s user 1,42s system 98% cpu 1:05,01 total
v4.1.8 with this patch:11,52s user 1,29s system 94% cpu 13,576 total
| } | ||
| } | ||
| $this->container->getCompiler()->getServiceReferenceGraph()->clear(); | ||
| $checkedNodes =array(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
looks unused? should it beunset($checkedNodes);?
nicolas-grekasNov 28, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
could be but that wouldn't provide anything more so not really needed
alexander-schranzNov 28, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
unset would avoid IDE or code style checker marking it as unused variable so nobody would remove it accidentally ;).
But I'm happy that the container now only take some seconds to build again 😄
nicolas-grekas commentedNov 28, 2018
@alexander-schranz thanks for the confirmation. |
and a few minor things found meanwhile.