Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fixes sprintf(): Too few arguments in Translator#29344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
xabbuh approved these changesNov 27, 2018
Fixes the log produced when the method is called : Before : "sprintf(): Too few arguments"After : "The "Symfony\Component\Translation\Translator::transChoice()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%count%" parameter."Reference :http://php.net/manual/function.sprintf.php
Member
nicolas-grekas commentedNov 27, 2018
Thank you@stephanedelprat. |
nicolas-grekas added a commit that referenced this pull requestNov 27, 2018
…delprat)This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes#29344).Discussion----------Fixes sprintf(): Too few arguments in Translator| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | related to a previous deprecation <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | ?| Fixed tickets | none| License | MIT| Doc PR | noneFixes the log produced when the method is called :Before : "sprintf(): Too few arguments"After : "The "Symfony\Component\Translation\Translator::transChoice()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%count%" parameter."Reference :http://php.net/manual/function.sprintf.phpCommits-------45c3de0 Fixes sprintf(): Too few arguments in Translator
Merged
nicolas-grekas added a commit that referenced this pull requestDec 6, 2018
…oiceFormat (stephanedelprat)This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes#29482).Discussion----------Fixes sprintf(): Too few arguments in MessageFormatter::choiceFormatSimilar to :#29344| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | related to a previous deprecation <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | I hope so| Fixed tickets | none| License | MIT| Doc PR | noneFixes the log produced when the method is called :Before : "sprintf(): Too few arguments"After : "The "Symfony\Component\Translation\Formatter\MessageFormatter::choiceFormat()" method is deprecated since Symfony 4.2, use the format() one instead with a %count% parameter."Reference :http://php.net/manual/function.sprintf.phpCommits-------109fee5 Fixes sprintf(): Too few arguments in Translator
symfony-splitter pushed a commit to symfony/translation that referenced this pull requestDec 6, 2018
SerhiyMytrovtsiy added a commit to SerhiyMytrovtsiy/translation that referenced this pull requestOct 19, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the log produced when the method is called :
Before : "sprintf(): Too few arguments"
After : "The "Symfony\Component\Translation\Translator::transChoice()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%count%" parameter."
Reference :http://php.net/manual/function.sprintf.php