Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] defer log message in guard authenticator#29323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| // abort the execution of the authenticator if it doesn't support the request | ||
| if (!$guardAuthenticator->supports($request)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
would it be useful to add a new log in this block then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe it helps debugging. I have added two more log messages.
prevent an unneccessary log message if the guard authenticator does not support the current request
f67a317 to21c3030Comparefabpot commentedDec 10, 2018
Thank you@eschultz-magix. |
…ltz-magix)This PR was merged into the 3.4 branch.Discussion----------[Security] defer log message in guard authenticatorprevent an unnecessary log message if the guard authenticator does not support the current request| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This PR defers log messages about "getCredentials()" method calls if more than one guard authentication provider is used. The method is only called if the provider supports the request. The log message may be confusing during development.Commits-------21c3030 [Security] defer log message in guard authenticator
Uh oh!
There was an error while loading.Please reload this page.
prevent an unnecessary log message if the guard authenticator does not support the current request
This PR defers log messages about "getCredentials()" method calls if more than one guard authentication provider is used. The method is only called if the provider supports the request. The log message may be confusing during development.