Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[EventDispatcher] Unwrap wrapped listeners internally#29305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesNov 24, 2018
chalasr approved these changesNov 24, 2018
ContributorAuthor
ro0NL commentedNov 25, 2018
I confirm the profiler deduplicates events. Ill try to take another stab at it in master to fully close#24275 |
fabpot approved these changesNov 26, 2018
Member
fabpot commentedNov 26, 2018
Thank you@ro0NL. |
fabpot added a commit that referenced this pull requestNov 26, 2018
This PR was merged into the 3.4 branch.Discussion----------[EventDispatcher] Unwrap wrapped listeners internally| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | partially#24275| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->I believe what happens is we re-register the listeners on the wrapped dispatcher, so in case of sub request we get those and wrap it again. The profiler seems to confirm this in case of an exception (default 404 here) and thus creates a sub-request.## Before: (main request)No exception: (OK)Exception: (KO)## After (main request):No exception: sameException: (OK)I haven't furhter investigated if we should split events per request as done in#23659 for logs. It seems somewhere we deduplicate events.. so im not sure the profiler actually shows correct data.Commits-------448e2e2 [EventDispatcher] Unwrap wrapped listeners internally
This was referencedNov 26, 2018
Merged
Merged
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I believe what happens is we re-register the listeners on the wrapped dispatcher, so in case of sub request we get those and wrap it again. The profiler seems to confirm this in case of an exception (default 404 here) and thus creates a sub-request.
Before: (main request)
No exception: (OK)
Exception: (KO)
After (main request):
No exception: same
Exception: (OK)
I haven't furhter investigated if we should split events per request as done in#23659 for logs. It seems somewhere we deduplicate events.. so im not sure the profiler actually shows correct data.