Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] add welcome notice when running the command#29303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedNov 24, 2018•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

The current behavior of./bin/console messenger:consume-messages is totally silent: you run it and nothing visible happens.

Here is what is displayed with this PR:
image

Combined with#30539, it gives:
image

Koc and bigfoot90 reacted with thumbs up emoji
@ro0NL
Copy link
Contributor

ro0NL commentedNov 24, 2018•
edited
Loading

class ConsoleLoggerextends AbstractLogger

?

So yeah, let Worker/Receiver produce PSR logs. And provide a new ConsoleLogger or "the logger" in the "messenger" channel for that matter from the command?

@nicolas-grekasnicolas-grekas added this to thenext milestoneNov 25, 2018
@dmaicher
Copy link
Contributor

do we have a standard way of decorating an Output instance with a logger to achieve that?

was also wondering about that recently. There isSymfony\Bridge\Monolog\Handler\ConsoleHandler but its specific to Monolog 😋

@Koc
Copy link
Contributor

Koc commentedDec 4, 2018

What about adding also somewriteln likeStart consuming messages from transport "amqp".?

@weaverryan
Copy link
Member

This bothers me too.

What about adding also some writeln likeStart consuming messages from transport "amqp".?

+1 for this

which then leads to: shouldn't we inject a logger instead of an output instance?

Yea, let's injectmonolog.logger.messenger and just log to it. Then, of course, people won't see the log messages in the console, by default. That can be solved by telling the user to use-v:

Consuming messages from transport "amqp".
Re-run the command with a-v option to see more details.

@weaverryanweaverryan mentioned this pull requestMar 12, 2019
36 tasks
@nicolas-grekasnicolas-grekas changed the title[Messenger] log messages that are consumed by the command[Messenger] add welcome notice when running the commandMar 12, 2019
@nicolas-grekas
Copy link
MemberAuthor

Status: needs review

Copy link
Member

@weaverryanweaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

+1

@nicolas-grekasnicolas-grekas merged commit673b58b intosymfony:masterMar 13, 2019
nicolas-grekas added a commit that referenced this pull requestMar 13, 2019
…d (nicolas-grekas)This PR was merged into the 4.3-dev branch.Discussion----------[Messenger] add welcome notice when running the command| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -The current behavior of `./bin/console messenger:consume-messages` is totally silent: you run it and nothing visible happens.Here is what is displayed with this PR:![image](https://user-images.githubusercontent.com/243674/54235039-af0a6c80-4510-11e9-89d8-3c1c55e946c0.png)Combined with#30539, it gives:![image](https://user-images.githubusercontent.com/243674/54235156-ed079080-4510-11e9-9d4d-9f27c87e16e5.png)Commits-------673b58b [Messenger] add welcome notice when running the command
@nicolas-grekasnicolas-grekas deleted the messenger-output branchMarch 15, 2019 13:41
@nicolas-grekasnicolas-grekas removed this from thenext milestoneApr 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@weaverryanweaverryanweaverryan approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

@srozesrozeAwaiting requested review from sroze

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

9 participants

@nicolas-grekas@ro0NL@dmaicher@Koc@weaverryan@fabpot@xabbuh@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp