Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel][WebProfilerBundle] Getting the cached client mime type instead of guessing it again#29285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ro0NL commentedNov 22, 2018
👍 for the new approach. Im not sure about "FILES parameters", that's not a real HTTP verb. In HTTP context we're dealing "multipart form-data" (part of the POST params). I suggest to keep the current title. At most it could be moved as |
yceruto commentedNov 22, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@ro0NL I thought "FILES Parameters" is more according to |
ro0NL commentedNov 22, 2018
Right, but im not sure we should use PHP terminology. It's also |
914ac1c to3d2877fComparesrc/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/request.html.twig OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
3d2877f to2e746bcCompareyceruto commentedNov 22, 2018
@ro0NL comments addressed, thanks! |
…nstead of guessing it again
2e746bc to38692a6Comparefabpot commentedNov 24, 2018
Thank you@yceruto. |
…mime type instead of guessing it again (yceruto)This PR was squashed before being merged into the 4.2-dev branch (closes#29285).Discussion----------[HttpKernel][WebProfilerBundle] Getting the cached client mime type instead of guessing it again| Q | A| ------------- | ---| Branch? | master (4.2)| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29284| License | MIT| Doc PR | -The 1st commit fixes the bug based on the current implementation. But I'd like to improve this new feature a little bit with the 2nd commit: * <del>Renaming "Uploaded files" title by "FILES Parameters" and</del> (sub-section of POST parameters) changing the table using key/value structure (being consistent with other sections). * The above allow us also to show nested paramaters. (It is useful to know where this file(s) comes from) * And show all info about the `UploadedFile` object. (It might be useful too)Commits-------38692a6 [HttpKernel][WebProfilerBundle] Getting the cached client mime type instead of guessing it again
Uh oh!
There was an error while loading.Please reload this page.
The 1st commit fixes the bug based on the current implementation. But I'd like to improve this new feature a little bit with the 2nd commit:
Renaming "Uploaded files" title by "FILES Parameters" and(sub-section of POST parameters) changing the table using key/value structure (being consistent with other sections).UploadedFileobject. (It might be useful too)