NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

FIX PHPUNIT (404 Error when download phpunit)#29263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

qlaffont-smiirl wants to merge2 commits intosymfony:3.4fromqlaffont-smiirl:patch-1

Closed

FIX PHPUNIT (404 Error when download phpunit)#29263

qlaffont-smiirl wants to merge2 commits intosymfony:3.4fromqlaffont-smiirl:patch-1

Conversation

Copy link

qlaffont-smiirl commentedNov 19, 2018•
edited
Loading

At this time, 5.7 & 4.8 ZIP return 404 error. So we can change to 5.7.26 & 4.8.36 ZIP.

Q	A
Branch?	For All
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR	symfony/symfony-docs#...

PHPUNIT 5.7 -> 5.7.26 (404 Error when download phpunit)

1b232a1

At this time, 5.7 ZIP return 404 error. So we can change to 5.7.26 ZIP.

carsonbot added Status: Needs Review Bug labels

Nov 19, 2018

qlaffont-smiirl changed the title ~~PHPUNIT 5.7 -> 5.7.26 (404 Error when download phpunit)~~FIX PHPUNIT (404 Error when download phpunit)

Nov 19, 2018

FIX 4.8 too

4095805

4.8 -> 4.8.36

Copy link

Author

qlaffont-smiirl commentedNov 19, 2018•
edited
Loading

Appveyor test doesn't work because it doesn't take the modification I have to do.

Copy link

Contributor

l-vo commentedNov 20, 2018

I confirm the issue :(

Copy link

Member

nicolas-grekas commentedNov 20, 2018

See#29264

l-vo reviewed

Nov 20, 2018

View reviewed changes

src/Symfony/Bridge/PhpUnit/bin/simple-phpunit

		}elseif (PHP_VERSION_ID >=50600) {
		// PHPUnit 4 does not support PHP 7
		$PHPUNIT_VERSION =getenv('SYMFONY_PHPUNIT_VERSION') ?:'5.7';
		$PHPUNIT_VERSION =getenv('SYMFONY_PHPUNIT_VERSION') ?:'5.7.26';

Copy link

Contributor

l-voNov 20, 2018•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

6.5, 5.7 and 4.8 seem to be aliases for the latest patch versions. We can't fix it to a specific patch version (problem to maintain it). And maybe 4.8 and 5.7 aliases will be available again soon. What about use a fallback if the zip is not found and use github api for selecting the latest patch tag ?

Copy link

Member

nicolas-grekasNov 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's try saving us from any additional complexity.
Let's lobbysebastianbergmann/phpunit#3413

nicolas-grekas mentioned this pull request

Nov 20, 2018

PHPUnit Version 5.7 Removedsebastianbergmann/phpunit#3413

Closed

Copy link

Member

nicolas-grekas commentedNov 20, 2018

Reported insebastianbergmann/phpunit#3413

Copy link

tonivdv commentedNov 20, 2018

I fixed this issue (but for php >=7.2) by changing the env SYMFONY_PHPUNIT_VERSION from 7.2 to 7.4 in bin/phpunit file.

I guess this is what needs to be done in the bridge ... aligning the valid versions according to the php versions?!

Copy link

Author

qlaffont-smiirl commentedNov 20, 2018

Yes me too, I have set the env var SYMFONY_PHPUNIT_VERSION and it solve the problem. But we need to change it on the file for default env.

Copy link

Author

qlaffont-smiirl commentedNov 20, 2018

@nicolas-grekas , the author answer it. Can we merge it ?

Copy link

Member

stof commentedNov 20, 2018

A solution might be to switch tocomposer create-project phpunit/phpunit 5.7 '5.7.* --no-install --prefer-dist instead of downloading the branch from Github. This way, composer would download the latest patch release properly (and--no-install still allows us to alter the dependencies before installing them)

nicolas-grekas mentioned this pull request

Nov 20, 2018

[Bridge/PhpUnit] Use composer to download phpunit#29265

Merged

Copy link

Member

nicolas-grekas commentedNov 20, 2018

@stof brilliant idea! See#29265

nicolas-grekas added this to the3.4 milestone

Nov 20, 2018

Copy link

Member

nicolas-grekas commentedNov 20, 2018

Closing in favor of#29265
Thanks for raising the point and suggesting the change!

nicolas-grekas closed this

Nov 20, 2018

nicolas-grekas added a commit that referenced this pull request

Nov 20, 2018

bug#29265[Bridge/PhpUnit] Use composer to download phpunit (nicolas…

e166d96

…-grekas)This PR was merged into the 3.4 branch.Discussion----------[Bridge/PhpUnit] Use composer to download phpunit| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#27753,#29263,#29264| License       | MIT| Doc PR        | -Commits-------e823f1d [Bridge/PhpUnit] Use composer to download phpunit

qlaffont-smiirl deleted the patch-1 branch

November 20, 2018 16:20