Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpFoundation] Fixed absolute Request URI with default port#29256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@thomasbisignani
Copy link
Contributor

@thomasbisignanithomasbisignani commentedNov 18, 2018
edited by javiereguiluz
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29234
LicenseMIT
Doc PR

This PR fixes the#29234 issue, the request URI with default port was not properly generated.

Example :

$request = Request::create('http://test.com:80/foo');$request->server->set('REQUEST_URI','http://test.com:80/foo');

Before this fix, the$request->getUri() method returnedhttp://test.com/:80/foo :

Failed asserting that two strings are equal.--- Expected+++ Actual@@ @@-'http://test.com/foo'+'http://test.com/:80/foo'

@thomasbisignanithomasbisignaniforce-pushed thefix/httpfoundation-request-uri-with-default-port branch 2 times, most recently from58224ba todbde28eCompareNovember 18, 2018 23:28
@thomasbisignanithomasbisignani changed the title[HttpFoundation] Fixed request URI with default port[HttpFoundation] Fixed absolute Request URI with default portNov 18, 2018
@thomasbisignanithomasbisignaniforce-pushed thefix/httpfoundation-request-uri-with-default-port branch fromdbde28e to310d4d1CompareNovember 19, 2018 08:53
@thomasbisignanithomasbisignaniforce-pushed thefix/httpfoundation-request-uri-with-default-port branch from310d4d1 to2e8f480CompareNovember 19, 2018 09:48
@thomasbisignanithomasbisignaniforce-pushed thefix/httpfoundation-request-uri-with-default-port branch from2e8f480 tocddce2aCompareNovember 20, 2018 16:51
@fabpot
Copy link
Member

Thanks for fixing this bug@thomasbisignani.

thomasbisignani reacted with thumbs up emoji

@fabpotfabpot merged commitcddce2a intosymfony:3.4Nov 24, 2018
fabpot added a commit that referenced this pull requestNov 24, 2018
…ort (thomasbisignani)This PR was merged into the 3.4 branch.Discussion----------[HttpFoundation] Fixed absolute Request URI with default port| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#29234| License       | MIT| Doc PR        |This PR fixes the#29234 issue, the request URI with default port was not properly generated.Example :```php$request = Request::create('http://test.com:80/foo');$request->server->set('REQUEST_URI', 'http://test.com:80/foo');```Before this fix, the `$request->getUri()` method returned `http://test.com/:80/foo` :```diffFailed asserting that two strings are equal.--- Expected+++ Actual@@ @@-'http://test.com/foo'+'http://test.com/:80/foo'```Commits-------cddce2a [HttpFoundation] Fixed absolute Request URI with default port
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@ro0NLro0NLro0NL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@thomasbisignani@fabpot@javiereguiluz@nicolas-grekas@ro0NL@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp