Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Fixed absolute Request URI with default port#29256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:3.4fromthomasbisignani:fix/httpfoundation-request-uri-with-default-portNov 24, 2018
Merged
[HttpFoundation] Fixed absolute Request URI with default port#29256
fabpot merged 1 commit intosymfony:3.4fromthomasbisignani:fix/httpfoundation-request-uri-with-default-portNov 24, 2018
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
58224ba todbde28eCompareUh oh!
There was an error while loading.Please reload this page.
dbde28e to310d4d1CompareUh oh!
There was an error while loading.Please reload this page.
310d4d1 to2e8f480Comparero0NL approved these changesNov 19, 2018
Uh oh!
There was an error while loading.Please reload this page.
2e8f480 tocddce2aComparenicolas-grekas approved these changesNov 20, 2018
fabpot approved these changesNov 24, 2018
Member
fabpot commentedNov 24, 2018
Thanks for fixing this bug@thomasbisignani. |
fabpot added a commit that referenced this pull requestNov 24, 2018
…ort (thomasbisignani)This PR was merged into the 3.4 branch.Discussion----------[HttpFoundation] Fixed absolute Request URI with default port| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29234| License | MIT| Doc PR |This PR fixes the#29234 issue, the request URI with default port was not properly generated.Example :```php$request = Request::create('http://test.com:80/foo');$request->server->set('REQUEST_URI', 'http://test.com:80/foo');```Before this fix, the `$request->getUri()` method returned `http://test.com/:80/foo` :```diffFailed asserting that two strings are equal.--- Expected+++ Actual@@ @@-'http://test.com/foo'+'http://test.com/:80/foo'```Commits-------cddce2a [HttpFoundation] Fixed absolute Request URI with default port
This was referencedNov 26, 2018
Merged
Merged
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR fixes the#29234 issue, the request URI with default port was not properly generated.
Example :
Before this fix, the
$request->getUri()method returnedhttp://test.com/:80/foo: