Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Added the condition routing option to the debug router command#29254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[FrameworkBundle] Added the condition routing option to the debug router command#29254
Uh oh!
There was an error while loading.Please reload this page.
Conversation
OskarStark commentedNov 20, 2018
Thank you for your contribution. |
soufianZantar commentedNov 20, 2018
@OskarStark thank you for your review. |
soufianZantar commentedNov 20, 2018
Hi@OskarStark this is the srceenshots
|
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/JsonDescriptor.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/MarkdownDescriptor.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
56cf697 to2fdd7e5ComparesoufianZantar commentedNov 22, 2018
hi@ro0NL and whyAppVeyor return |
ro0NL left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
failures unrelated
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/MarkdownDescriptor.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
2fdd7e5 to0b2d9f4Compare0b2d9f4 to92bdc9bComparefabpot commentedMar 4, 2019
Thank you@soufianZantar. |
…o the debug router command (soufianZantar)This PR was squashed before being merged into the 4.3-dev branch (closes#29254).Discussion----------[FrameworkBundle] Added the condition routing option to the debug router command| Q | A| ------------- | ---| Branch? | master <!-- see below -->| Bug fix? | no| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | <!-- required for new features --><!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->This PR will add the condition routing option to debug:router command, to show if a route have conditions or not and showing this conditions.Commits-------92bdc9b [FrameworkBundle] Added the condition routing option to the debug router command
This PR was merged into the master branch.Discussion----------Minor tweak for the debug:router outputJust a minor mention of the change made insymfony/symfony#29254Commits-------2a29904 Minor tweak for the debug:router output





This PR will add the condition routing option to debug:router command, to show if a route have conditions or not and showing this conditions.