Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Added the condition routing option to the debug router command#29254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@soufianZantar
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

This PR will add the condition routing option to debug:router command, to show if a route have conditions or not and showing this conditions.

@OskarStark
Copy link
Contributor

Thank you for your contribution.
Can you please show some output with a screenshot?

@soufianZantar
Copy link
ContributorAuthor

@OskarStark thank you for your review.
Yes, i will show you the output tonight (sadly i can't now).

@soufianZantar
Copy link
ContributorAuthor

Hi@OskarStark this is the srceenshots

bin/console debug:router routing_without_condition

routing-1

bin/console debug:router routing_with_condition

routing-2

bin/console debug:router --format=json

routing-3

bin/console debug:router --format=md

routing-4

bin/console debug:router --format=xml

routing-5

OskarStark reacted with thumbs up emoji

@soufianZantarsoufianZantarforce-pushed theadded_condition_to_debug_router branch 2 times, most recently from56cf697 to2fdd7e5CompareNovember 22, 2018 22:02
@soufianZantar
Copy link
ContributorAuthor

hi@ro0NL
I have added your suggestion, what you think now?

and whyAppVeyor returnCommand exited with code -1073741819? all tests was passed, is that normal?

Copy link
Contributor

@ro0NLro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

failures unrelated

@soufianZantarsoufianZantarforce-pushed theadded_condition_to_debug_router branch from2fdd7e5 to0b2d9f4CompareDecember 14, 2018 22:33
@fabpotfabpotforce-pushed theadded_condition_to_debug_router branch from0b2d9f4 to92bdc9bCompareMarch 4, 2019 09:21
@fabpot
Copy link
Member

Thank you@soufianZantar.

soufianZantar reacted with hooray emoji

@fabpotfabpot merged commit92bdc9b intosymfony:masterMar 4, 2019
fabpot added a commit that referenced this pull requestMar 4, 2019
…o the debug router command (soufianZantar)This PR was squashed before being merged into the 4.3-dev branch (closes#29254).Discussion----------[FrameworkBundle] Added the condition routing option to the debug router command| Q             | A| ------------- | ---| Branch?       | master <!-- see below -->| Bug fix?      | no| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        |  <!-- required for new features --><!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->This PR will add the condition routing option to debug:router command, to show if a route have conditions or not and showing this conditions.Commits-------92bdc9b [FrameworkBundle] Added the condition routing option to the debug router command
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestApr 1, 2019
This PR was merged into the master branch.Discussion----------Minor tweak for the debug:router outputJust a minor mention of the change made insymfony/symfony#29254Commits-------2a29904 Minor tweak for the debug:router output
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@ro0NLro0NLro0NL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

7 participants

@soufianZantar@OskarStark@fabpot@nicolas-grekas@ro0NL@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp