Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Added the missing constraints instance checks#29223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@thomasbisignani
Copy link
Contributor

QA
Branch?2.8
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

This PR adds the constraints instance checks missing to limit the validators use.

This behavior is already implemented in all built-in validators, but it was missed in two validators.

@ro0NL
Copy link
Contributor

i think we should target master for this, as a new feature. IMHO a deprecation is not really worth it, so 👍 for throwing.

@stof
Copy link
Member

Well, the code of the validator already expects the right class due to property being used. So these are about providing a good error message in case you mess your project configuration, but it probably already does not work (with a crappier error message) in case of such mess.
So 👍 for adding the exception directly.

thomasbisignani reacted with thumbs up emoji

@ro0NL
Copy link
Contributor

@stof unless someone completely mimics the exepcted api with its own constraint class :}

@nicolas-grekas
Copy link
Member

Thank you@thomasbisignani.

thomasbisignani reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit0ecaead intosymfony:2.8Nov 15, 2018
nicolas-grekas added a commit that referenced this pull requestNov 15, 2018
…(thomasbisignani)This PR was merged into the 2.8 branch.Discussion----------[Validator] Added the missing constraints instance checks| Q             | A| ------------- | ---| Branch?       | 2.8| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |This PR adds the constraints instance checks missing to limit the validators use.This behavior is already implemented in all built-in validators, but it was missed in two validators.Commits-------0ecaead [Validator] Added the missing constraints instance checks
@fabpotfabpot mentioned this pull requestNov 16, 2018
This was referencedNov 26, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

2.8

Development

Successfully merging this pull request may close these issues.

5 participants

@thomasbisignani@ro0NL@stof@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp