Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] make intl+icu format seamless by handling it in MessageCatalogue#29220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedNov 14, 2018•
edited
Loading

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29136
LicenseMIT
Doc PR-

Copy link
Contributor

@gharlangharlan left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It fixes my issue (tested profiler and commanddebug:translation)
Thanks@nicolas-grekas!

@nicolas-grekas
Copy link
MemberAuthor

Now with tests. PR ready.

@stof
Copy link
Member

@nicolas-grekas wouldn'ttransChoice now also go look in the Intl-ICU domain, but without switching to the Intl formatter ?

@nicolas-grekas
Copy link
MemberAuthor

It could, but that'd mean make a new feature accessible via a deprecated API. I'd prefer not allowing it. OK for you?

@nicolas-grekas
Copy link
MemberAuthor

OH, GOT IT.
Yes. I wouldn't care :)
New format with deprecated transChoice => not supported :)

@nicolas-grekas
Copy link
MemberAuthor

GRR. OK, fixed. Good catch@stof :)

@nicolas-grekasnicolas-grekas merged commitc71dfb9 intosymfony:masterNov 15, 2018
nicolas-grekas added a commit that referenced this pull requestNov 15, 2018
… in MessageCatalogue (nicolas-grekas)This PR was merged into the 4.2-dev branch.Discussion----------[Translation] make intl+icu format seamless by handling it in MessageCatalogue| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#29136| License       | MIT| Doc PR        | -Commits-------c71dfb9 [Translation] make intl+icu format seamless by handling it in MessageCatalogue
@fabpotfabpot mentioned this pull requestNov 16, 2018
@nicolas-grekasnicolas-grekas deleted the translation-fix branchNovember 18, 2018 15:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

+1 more reviewer

@gharlangharlangharlan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@stof@gharlan@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp